ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

[Feature] Conver to v2 addon for use in regular ESM projects

Open NullVoxPopuli opened this issue 3 years ago • 2 comments

I hadn't seen an issue for this (if this is a duplicate, feel free to close).

I'm working on something, and noticed that when installing ember-source in a non-traditional ember project, I see these package manager messages:

 WARN  Issues with peer dependencies found
ember-addon-test
├─┬ ember-source
│ └─┬ ember-auto-import
│   ├─┬ babel-loader
│   │ └── ✕ missing peer webpack@>=2
│   ├─┬ css-loader
│   │ └── ✕ missing peer webpack@"^4.27.0 || ^5.0.0"
│   ├─┬ mini-css-extract-plugin
│   │ └── ✕ missing peer webpack@^5.0.0
│   └─┬ style-loader
│     └── ✕ missing peer webpack@"^4.0.0 || ^5.0.0"
└─┬ vite-plugin-babel
  └── ✕ unmet peer vite@^2.7.0: found 3.0.7
Peer dependencies that should be installed:
  webpack@">=5.0.0 <6.0.0"  

I don't want to install ember-auto-import or webpack. (but I know these are required for ember v1 addons)

NullVoxPopuli avatar Aug 12 '22 21:08 NullVoxPopuli

Hi, we encounter this as well when trying to move our addon to V2. Is that something we can ignore ?

sly7-7 avatar Sep 19 '24 07:09 sly7-7

They're safe to ignore - can be done with pnpm config, like here https://github.com/NullVoxPopuli/ember-resources/blob/main/package.json#L39

NullVoxPopuli avatar Sep 19 '24 12:09 NullVoxPopuli