ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

feat: add isExternal argument to simplify ember-engines

Open BobrImperator opened this issue 3 years ago • 1 comments

  • Adds isExternal argument to LinkTo component
    • based on the flag it disables assertions that are causing Routeless engines to fail, ember-engines internally overrides them.
    • based on the flag, it changes the behavior of namespaceRoute method, so it uses the provided route directly without changing it further - in that case ember-engines is responsible for passing correctly resolved routes.

BobrImperator avatar Aug 03 '22 11:08 BobrImperator

@BobrImperator FYI this contradicts the long term and more stable solution proposed in https://github.com/emberjs/rfcs/pull/819

SergeAstapov avatar Aug 03 '22 12:08 SergeAstapov

Closing since it contradicts the RFC

kategengler avatar Dec 12 '23 16:12 kategengler