ember.js
ember.js copied to clipboard
[Bug] ember API documentation has broken links to node_modules
π Describe the Bug
Some API documentation hosted under https://api.emberjs.com/ember/4.4 references paths under node_modules in the "Defined in" tag. Clicking the link results in an error on GitHub about the repository not containing a file at that path.
π¬ Minimal Reproduction
- Open the documentation for RSVP's All function.
- Click the "Defined in node_modules/rsvp/lib/rsvp/all.js:3" link.
π Actual Behavior
After clicking the link from the Minimal Reproduction section above, GitHub shows a 404 error and displays the message: "The 'emberjs/ember.js' repository doesn't contain the 'node_modules/rsvp/lib/rsvp/all.js' path in 'v4.4.0'."
π€ Expected Behavior
Either exclude documentation coming from node_modules from the published bundle or tweak the implementation so that we end up with working links.
@emberjs/learning-team-managers
Thanks for reporting!
One additional option is to make a small change in the app to omit this link or point it to RSVP directly.
My understanding is that RSVP available to use through Ember, but itβs a separate package.