ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

Improve API documentation for @ember/debug deprecate

Open locks opened this issue 2 years ago • 6 comments

Currently, deprecate from @ember/debug has very barebones API documentation: https://api.emberjs.com/ember/4.4/functions/@ember%2Fdebug/deprecate.

Tasks

  • [x] Improve options type to state which options are supported.
  • [ ] Improve description to include information about Ember's deprecation system
  • [ ] Add code snippet with example usage. Can be taken from the ember.js source code itself.

locks avatar May 28 '22 11:05 locks

I can take a look at this in the next day or two.

geneukum avatar May 29 '22 16:05 geneukum

Hey, I would like to take this task. Where can I find the documentation file?

kirtan-desai avatar Jun 19 '22 02:06 kirtan-desai

@geneukum @kirtan-desai thank you for your interest! In general a good way to find where a certain function is in the source code is to check the "Defined in:" link in the API docs: image which in this case links to https://github.com/emberjs/ember.js/blob/v4.4.0/packages/%40ember/debug/lib/deprecate.ts#L181. There are a couple of cases where the links point to the wrong place, but that should be rare and we should fix it anyway.

locks avatar Jul 15 '22 09:07 locks

Visiting the page on the API docs I noticed that we are not surfacing what the options object contains, so only the two other tasks remain!

locks avatar Jul 15 '22 09:07 locks

@locks, I think that the other two options may be covered by https://github.com/emberjs/ember.js/pull/20124.

geneukum avatar Jul 15 '22 10:07 geneukum

Hi i'd like to help. Where i have to start?

GieralZiomal avatar Aug 23 '22 14:08 GieralZiomal

Hey @locks, I would like to add Improve description ?

pratham-bhatnagar avatar Oct 07 '22 12:10 pratham-bhatnagar

I can work on this

legendkartik45 avatar Jan 09 '23 04:01 legendkartik45

Is this issue opened still?

Blueclaus13 avatar Feb 10 '23 20:02 Blueclaus13

It looks like #20124 address the remaining issues. Can this be closed or are there further changes needed for the docs?

RyanMuzzey avatar Mar 29 '23 21:03 RyanMuzzey