ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

[Documentation] Missing property isAborted in Transition class

Open MarcoUmpierrez opened this issue 4 years ago • 2 comments

📙 Describe the Issue

The property isAborted is missing from the class Transition although this property still exists. I've tried to find it in the old API docs but I couldn't find it.

🔬 Minimal Reproduction

https://api.emberjs.com/ember/3.20/classes/Transition

😕 Actual Behavior

Transition class is missing the property isAborted.

🤔 Expected Behavior

isAborted property should be documented.

➕ Additional Context

MarcoUmpierrez avatar Aug 04 '20 17:08 MarcoUmpierrez

Hi, I'm actually experiment this lack in the documentation.

The RouterService routeDidChange event describe that abort substates are also fired, but how ignore aborted transition ? https://api.emberjs.com/ember/3.28/classes/RouterService/events/routeDidChange?anchor=routeDidChange

ncoquelet avatar Oct 04 '21 10:10 ncoquelet

Hello all,

Same issue here. And this property is even used in a blog post here:

https://balinterdi.com/blog/warning-about-losing-unsaved-changes-in-ember-octane/

MonsieurDart avatar Apr 12 '22 15:04 MonsieurDart