ember.js
ember.js copied to clipboard
Add failing test for query param scoping
The issue here is that for query param scoping, it is assumed that the only thing that matters are the URL params on the final route. However, it is entirely possible (as shown in the test) that this might not be sufficient to determine uniqueness. It's not clear to me how best to fix this since in some cases this assumption might be correct (e.g. the params are just the ids of Ember Data records) but in others it may not be (e.g. the final route's params aren't sufficient to determine the model).
It should also be noted that the guides say that the query params are tied to the model. This is definitely not correct as we see here. They are tied to the url params of the last route.
Is this a regression as of 3.6?
@chadhietala I believe it's been present since at least 3.4.6 as we discovered it in our app which is stuck on 3.4 for unrelated reasons.
@wagenet is this still relevant?
@locks I just rebased. Looks like CI still fails.
Is this still relevant?
Rebased again just now.