ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

Add failing test for query param scoping

Open wagenet opened this issue 5 years ago • 6 comments

The issue here is that for query param scoping, it is assumed that the only thing that matters are the URL params on the final route. However, it is entirely possible (as shown in the test) that this might not be sufficient to determine uniqueness. It's not clear to me how best to fix this since in some cases this assumption might be correct (e.g. the params are just the ids of Ember Data records) but in others it may not be (e.g. the final route's params aren't sufficient to determine the model).

It should also be noted that the guides say that the query params are tied to the model. This is definitely not correct as we see here. They are tied to the url params of the last route.

wagenet avatar Jan 08 '19 21:01 wagenet

Is this a regression as of 3.6?

chadhietala avatar Jan 09 '19 00:01 chadhietala

@chadhietala I believe it's been present since at least 3.4.6 as we discovered it in our app which is stuck on 3.4 for unrelated reasons.

wagenet avatar Jan 09 '19 00:01 wagenet

@wagenet is this still relevant?

locks avatar Feb 05 '22 19:02 locks

@locks I just rebased. Looks like CI still fails.

wagenet avatar Feb 07 '22 17:02 wagenet

Is this still relevant?

kategengler avatar Dec 12 '23 17:12 kategengler

Rebased again just now.

wagenet avatar Jan 10 '24 22:01 wagenet