Aborted transitions propagate error to Ember.RSVP.on('error',...)

[olivia]

As seen in this example, aborted transitions (through redirection or manual abortion) propagates a TransitionAborted error to the RSVP error handler while in 1.x it does not. Was this an intentional change or is the error an erroneous error?

[pixelhandler]

@ofbriggs my best guess is that this commit - https://github.com/emberjs/ember.js/commit/94e1035a0eb66cc4d2a6624ff2557a331524f663 about 28 days ago addresses the behavior around TransitionAborted perhaps @chancancode or @rwjblue can answer this question.

[chancancode]

I doubt that my commit changed that particular behavior, but I personally agree that it seems better not to propagate this to RSVP, although I am not sure what exactly has changed.

I might be looking into something related next week (routes instrumentation), so if no one else have figured it out by then I might uncover why as part of that work.

[stefanpenner]

It seems like some internals are not handling the rejection, this should be considered a bug.

If the rejection is handled in the same turn, it does not propagate to on('error

[bkCDL]

Any update on this? I experience it in Ember 2.2.0 too.

[jbryson3]

For now I'm just hardcoding the name of the error as a workaround.

export default function onServerError(cb) {
  Ember.RSVP.on('error', (reason) => {
    // An aborted transition propogates an error to RSVP
    if(reason.name !== 'TransitionAborted') {
      cb(reason);
    }
  });
}

[stianpr]

Any progress on this? We're experiencing this on Ember 2.3 as well.

[remkoboschker]

+1

[stravid]

~~We experienced this same issue with our error tracking platform Sentry and solved it with a workaround seen in this commit. Maybe it helps someone :)~~

Edit: The Repository is no longer public.

[gertjanwytynck]

+1

[bugduino]

+1

[jemware]

+1

[devinus]

Thanks @stravid, this is exactly what I needed. Months of this bug and I finally found this thread and your workaround after much Google-fu. 🙇

[stravid]

Thanks for the kind words @devinus, I will try to write a little blog post so in the future not so much Google-fu is needed :)

[victor95pc]

Thanks @stravid, but it still not a solution, maybe we can add more args on the error callback to check if the model's request fail.

[tchak]

I just merged a fix in ember-cli-sentry https://github.com/damiencaselli/ember-cli-sentry/pull/67

[bichotll]

Experienced it in Ember 2.5 (we are in the process to update Ember version). For future reference, I recommend the use of ember-cli-sentry ^.

Before we found the origin of the error we even had to upgrade our sentry subscription due the amount of false alarms...plus one afternoon/evening...

[cbou]

I also lose some time to figure out this was a false positive error.

using transitionTo inside redirect is documented in the guide and in the API: https://emberjs.com/api/ember/2.18/classes/Route/methods/redirect?anchor=redirect

Nevertheless it still produces an error: https://ember-twiddle.com/41c21d19e962b4981c967e46228452bb

It would save the time of a lot of emberjs new comers

[dtropp]

@chancancode or @rwjblue Planning any changes to this behaviour? We are seeing this when we have a guard in a beforeModel() that transitions to a different route. We are still seeing it on Ember 2.16

[pixelhandler]

@Boubalou @bichotll @binoculars @bkCDL @bugduino @cbou @chancancode @devinus @dschmidt @dtropp @gertjanwytynck @jbryson3 @jemware @olivia @remkoboschker @stefanpenner @stianpr @stravid @tchak @victor95pc is this still an issue, perhaps we should close, what do you think?

[bichotll]

I barely use Ember nowadays, but I suppose you could try to reproduce it by forking this and updating the Ember version? http://emberjs.jsbin.com/wiruqobiqe/1/edit?output

[Boubalou]

Same as @bichotll, I ended up doing backend works lately and not much into Ember anymore. I will let you guys decide whatever is good for this. :)

[bugduino]

I do not have the chance to test it

[victor95pc]

I stoped using Ember, so I cant confirm it still a issue.

[mpirio]

It seems it still an issue : https://ember-twiddle.com/fe0e87339fd079e212d5713f5288ce58

[fpauser]

Yes, it is still an issue (tested with ember-3.5.0).

[saleswhale-vincent]

Still seeing this in 3.8

[robgarden]

Reproduction on 3.10.0: https://github.com/robgarden/ember-transition-aborted-reproduction

[markyky]

+1 on 2.18.2

[thec0keman]

For browser errors this seems like it is more of an issue of noise. However, with Fastboot this becomes a bit more difficult, since the throw will stop everything. I haven't been able to find a way to catch that particular error, and I suspect the issue is that the exception is being thrown inside of a promise error handler.

Out of curiosity, what is the value in that particular throw? I'm wondering if it could either be removed, or if the error handler could be moved so that it could be overridden.

[lucasm-iRonin]

@Boubalou @bichotll @binoculars @bkCDL @bugduino @cbou @chancancode @devinus @dschmidt @dtropp @gertjanwytynck @jbryson3 @jemware @olivia @remkoboschker @stefanpenner @stianpr @stravid @tchak @victor95pc is this still an issue, perhaps we should close, what do you think?

@pixelhandler it's still an issue - I can reproduce it on Ember 3.8.3. I think we should consider removing inactive label, especially @robgarden provided repo for reproduction.