ember-test-helpers
ember-test-helpers copied to clipboard
Input events should be instantiated with `{ composed: true }`
The composed
property determines whether an event that occurs in shadow DOM will bubble to the host element.
In HTML, all form control input events are composed [^1] [^2].
Presently, we are not instantiating input events with { composed: true }
. See for example fillIn and select. I have not looked if there are other places. It probably makes sense to make this change in fireEvent
itself similar to how bubbles is true by default.
[^1]: Search for "Fire an event named input" on https://html.spec.whatwg.org/multipage/input.html and https://html.spec.whatwg.org/multipage/form-elements.html.
[^2]: Change events are not composed.
Totally agree, thank you for noticing and reporting!
Here's a list of events that should be instantiated with { composed: true }
:
https://github.com/WICG/webcomponents/issues/513#issuecomment-224183937