ember-inspector
ember-inspector copied to clipboard
emberjs
chore(deps): remove unused AWS SDK for JavaScript
Description
From AWS SDK for JavaScript v2 README:
We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.
The dependency was added in https://github.com/emberjs/ember-inspector/pull/535 to upload panes. It was not removed in https://github.com/emberjs/ember-inspector/pull/2103
@trivikr we used to use this to upload to s3 I think. Are we not doing that anymore?
Are we not doing that anymore?
No. Removed in https://github.com/emberjs/ember-inspector/pull/2103
The aws-sdk is only in package.json https://github.com/search?q=repo%3Aemberjs%2Fember-inspector%20aws-sdk&type=code
@RobbieTheWagner Is there any other action needed to merge this PR?
I've rebase from main branch.
@trivikr last I checked there were CI failures. If things pass this time, we can merge.
Two tests are failing
[test:ember] not ok 54 Chrome 121.0 - [513 ms] - Object Inspector: Date fields are editable
[test:ember] ---
[test:ember] actual: >
[test:ember] 0
[test:ember] expected: >
[test:ember] 1
[test:ember] stack: >
[test:ember] at Object.<anonymous> (http://localhost:7357/testing/assets/tests.js:69[97](https://github.com/emberjs/ember-inspector/actions/runs/7962892649/job/21741229328?pr=2511#step:9:98):18)
[test:ember] at callHook (http://localhost:7357/testing/assets/chunk.vendors-node_modules_pnpm_ember-sinon-qunit_7_4_0_ember-source_4_12_4_qunit_2_20_1_sinon_17_0-4350b3.d8ddfb3c2619f4ab8a81.js:877:806)
[test:ember] at runHook (http://localhost:7357/testing/assets/chunk.vendors-node_modules_pnpm_ember-sinon-qunit_7_4_0_ember-source_4_12_4_qunit_2_20_1_sinon_17_0-4350b3.d8ddfb3c2619f4ab8a81.js:886:1)
[test:ember] at ProcessingQueue.processTaskQueue (http://localhost:7357/testing/assets/chunk.vendors-node_modules_pnpm_ember-sinon-qunit_7_4_0_ember-source_4_12_4_qunit_2_20_1_sinon_17_0-4350b3.d8ddfb3c2619f4ab8a81.js:1133:121)
[test:ember] at ProcessingQueue.advanceTaskQueue (http://localhost:7357/testing/assets/chunk.vendors-node_modules_pnpm_ember-sinon-qunit_7_4_0_ember-source_4_12_4_qunit_2_20_1_sinon_17_0-4350b3.d8ddfb3c2619f4ab8a81.js:1127:136)
[test:ember] at ProcessingQueue.advance (http://localhost:7357/testing/assets/chunk.vendors-node_modules_pnpm_ember-sinon-qunit_7_4_0_ember-source_4_12_4_qunit_2_20_1_sinon_17_0-4350b3.d8ddfb3c2619f4ab8a81.js:1125:83)
[test:ember] message: >
[test:ember] The correct amount of objectInspector:saveProperty messages are sent
[test:ember] negative: >
[test:ember] false
[test:ember] browser log: |
[test:ember] ...
[test:ember] not ok 55 Chrome 121.0 - [397 ms] - Object Inspector: Errors are correctly displayed
[test:ember] ---
[test:ember] stack: >
[test:ember] at http://localhost:7357/testing/assets/chunk.vendors-node_modules_pnpm_ember-sinon-qunit_7_4_0_ember-source_4_12_4_qunit_2_20_1_sinon_17_0-4350b3.d8ddfb3c2619f4ab8a81.js:1729:251
[test:ember] message: >
[test:ember] global failure: Expecting 1 objectInspector:saveProperty messages, got 0
[test:ember] negative: >
[test:ember] false
[test:ember] browser log: |
[test:ember] ...
The failing tests:
- Date fields are editable: https://github.com/emberjs/ember-inspector/blob/528d7b6ddb84d34e08f7a04ec35889aae6e0a336/tests/acceptance/object-inspector-test.js#L858-L939
- Errors are correctly displayed: https://github.com/emberjs/ember-inspector/blob/528d7b6ddb84d34e08f7a04ec35889aae6e0a336/tests/acceptance/object-inspector-test.js#L941-L982
I'm not sure why removal of unused aws-sdk should fail these tests.
@trivikr the lock file shows many more updates done to the packages. I'm not sure how you can reduce that to only 1 specific package.
Maybe if you only do pnpm uninstall <package> ?
Maybe if you only do pnpm uninstall
?
I used pnpm uninstall to remove the dependency, and force pushed.
Can you restart CI?