ember-inspector icon indicating copy to clipboard operation
ember-inspector copied to clipboard

Ember inspector not working unless I silent a deprecation

Open dbendaou opened this issue 2 years ago • 5 comments

Describe the bug My Ember inspector isn't working unless I add the following line to my deprecation-workflow file { handler: 'silence', matchId: 'ember.built-in-components.import' },

At least 4 people are affected by the same issue in my company on this project

Chrome Version 101.0.4951.64 (Official Build) (arm64) Ember inspector version Version 4.5.11

To Reproduce Steps to reproduce the behavior:

  1. Go to any ember app on chrome
  2. Open inspector
  3. The Ember tab is showing this Screenshot 2022-05-19 at 10 30 27

Expected behavior It should work without silencing the { handler: 'silence', matchId: 'ember.built-in-components.import' },

Environment Chrome Version 101.0.4951.64 (Official Build) (arm64) Ember Inspector | 4.5.11 Ember | 3.28.9 Ember Data | 3.27.1

dbendaou avatar May 19 '22 08:05 dbendaou

Hi @dbendaou do you have a public facing app we can debug with? I tried going to https://music.apple.com/us/browse and the inspector is working as intended.

RobbieTheWagner avatar May 19 '22 14:05 RobbieTheWagner

@rwwagner90 I wonder if the deprecation workflow is only available in dev mode? If that's the case, this can't be reproduced on https://music.apple.com/us/browse 🤔

On my side, I can reproduce it on localhost, but on the production build the ember inspector works great.

aoumiri avatar May 27 '22 08:05 aoumiri

@dbendaou, what is your setting for throwOnUnhandled in your deprecation workflow? One observation in my application is that if I set this to false then the Inspector works. My theory is that the Inspector itself has the ember.built-in-components.import deprecation which becomes an exception based on the deprecation workflow setting. Note that @ember/component/text-field is used by the inspector and not @ember/legacy-built-in-components as described in the deprecation docs.

gerryster avatar Jul 12 '22 16:07 gerryster

Yeah indeed mine is setup on throwOnUnhandled: true,

dbendaou avatar Jul 18 '22 09:07 dbendaou

@aoumiri this is because deprecations are stripped in production.

wagenet avatar Aug 09 '22 22:08 wagenet