ember-inflector
ember-inflector copied to clipboard
emberjs
"octopi" is incorrect
The -us ↔ -i forms come from Latin.
The word octopus is of Greek origin. It's Greek plural form is octopodes, but in English the word is commonly pluralized according to English rules: octopuses.
Since so many people fall for this error, some dictionaries mark octopi as a possible pluralization. Nevertheless, we should not support this common mistake.
Both the logic and the readme need to be fixed.
Prooflinks:
- https://grammarist.com/usage/octopi-octopuses/
- https://en.wikipedia.org/wiki/Octopus
This library aims to be compatible with ruby’s Active-support. So if they have this, we can also change.
Well, ActiveSupport has a documentation example that suggests adding octopi as an override: https://github.com/rails/rails/blob/b9ca94caea2ca6a6cc09abaffaad67b447134079/activesupport/lib/active_support/inflector/inflections.rb#L22
Then I suspect we should leave it as is.
That being said, I’m totally not apposed to a secondary language pack / config option, that has a more actively maintained language list
@lolmaus I just check, it does support octopus -> octopi:
gem install activesupport
irb
irb(main):008:0> require 'active_support/all'
=> true
irb(main):009:0> 'octopus'.pluralize
=> "octopi"
We will totally accept a PR to correct this.
@lolmaus Thanks for taking the time to care about the little details like this! From one fellow grammar nerd to another, much appreciated <3
