[QUEST] v8 Release

[bertdeblock]

• [x] Move @babel/core to peerDependencies - https://github.com/babel/ember-cli-babel/pull/452
• [x] Drop support for Node v6, v8, v10 and v12 (Add support for Node v14, v16 and v18) - https://github.com/babel/ember-cli-babel/pull/454
• [x] Remove includePolyfill support - https://github.com/babel/ember-cli-babel/pull/458
• [x] Change broccoli-babel-transpiler to either make @babel/core a peer dependency or make it accept the current Babel as an argument, and upgrade ember-cli-babel to that version (without this we're still not actually transpiling people's code with the version of @babel/core in their own package.json) - https://github.com/babel/broccoli-babel-transpiler/pull/221
• [ ] Update broccoli-babel-transpiler to v8
• [ ] Write upgrade guide for apps and addons

[kategengler]

from @rwjblue in Discord

rwjblue — 09/16/2022 Agree There’s a non trivial amount of cleanup we should do though Like bumping the broccoli-Babel-transpiler version Changing poly fill support around (removing it basically)

[ef4]

Also just noticed that broccoli-babel-transpiler has @babel/core in dependencies. That means we should also change and release broccoli-babel-transpiler to either use a peerDep or accept babel itself as an argument when you create the broccoli node.

[ef4]

(I can't edit the description above, so I'm rewriting it here with updates.)

• [x] move @babel/core to peerDependencies https://github.com/babel/ember-cli-babel/pull/452
• [x] drop support for node < 14 and add test coverage for 14 through 18
• [x] remove includePolyfill support
• [x] change broccoli-babel-transpiler to either make @babel/core a peerDep or make it accept the current Babel as an argument, and upgrade ember-cli-babel to that version. (Without this we're still not actually transpiling people's code with the version of @babel/core in their own package.json.)

[bertdeblock]

@ef4 For the broccoli-babel-transpiler update, which option do you prefer / is best in this case?

[bertdeblock]

Also, does includePolyfill support need to be dropped without a replacement?

[bertdeblock]

Created PRs for the remaining issues. Hope I understood everything correctly 😄.

Probably need some guidance on the "Remove includePolyfill support" issue.

[ef4]

Also, does includePolyfill support need to be dropped without a replacement?

babel has deprecated the polyfill and tells you the replacement is to add import "core-js/stable" yourself: https://babeljs.io/docs/en/babel-polyfill

This probably belongs in changelog and in any how-to-upgrade doc that we may write for this major release.

[rwjblue]

I released https://github.com/babel/broccoli-babel-transpiler/releases/tag/v8.0.0-beta.1 so we can start updating here a bit easier

[bertdeblock]

👍 I'll try to fix the broccoli-babel-transpiler update here asap.

[ef4]

We're going to need to document what addon authors are supposed to do. They traditionally must have ember-cli-babel in dependencies and therefore they bring their own babel into app builds. The way to reproduce that after this change is for addons to @babel/core in dependencies. But it's probably better for them to put it into peerDependencies (and devDependencies).

[bertdeblock]

After the transpiler PR, I can look into writing an upgrade guide for apps and addons.

[ef4]

I said about "it's probably better for them to put it into peerDependencies", but after thinking about it, the less disruptive change is to put @babel/core into dependencies. That is equivalent to how things already worked, with every addon potentially bringing its own babel. We don't need to rock that boat any harder, the longer-term plan is for them to get to v2 addons and then they don't bring ember-cli-babel at all.

[JackHowa]

Excited to see babel polyfills removed 👍

[bertdeblock]

v8 is released.

[ef4]

Thank you @bertdeblock!