data icon indicating copy to clipboard operation
data copied to clipboard

pre-rfc: deprecate Store service extending EmberObject

Open runspired opened this issue 2 years ago • 3 comments
trafficstars

Currently Store extends from EmberObject. This is one of the last few entanglements EmberData has with the Ember framework directly.

We would like to RFC deprecating any inherited EmberObject methods or behaviors to support #8147 and to broaden our compatibility with a wider range of Ember.js versions as well.

This does not need to be a very involved RFC. Roughly equivalent to [https://github.com/emberjs/rfcs/pull/745]. The primary impact will be that anyone using Store.reopen or Store.extend will need to instead use native class extends. class Store extends BaseStore {}

runspired avatar Sep 17 '23 08:09 runspired

Could you provide more context?

thevinitgupta avatar Sep 18 '23 11:09 thevinitgupta

@thevinitgupta added

runspired avatar Sep 18 '23 17:09 runspired

example previous deprecation implementation for ember object methods https://github.com/emberjs/data/blob/900ce877f041d2c2736ce33716582f95f56bd936/packages/store/src/-private/record-arrays/identifier-array.ts#L647C11-L674

runspired avatar Sep 29 '23 17:09 runspired

RFC https://github.com/emberjs/rfcs/pull/1026

runspired avatar May 11 '24 10:05 runspired