data icon indicating copy to clipboard operation
data copied to clipboard

Published 20 hours ago • verified publisher icon emberjs

ci: the no-rollup asset-size check is broken

Open runspired opened this issue 2 years ago • 1 comments

The check passes because it is always reporting the size as zero 🤦🏻

runspired avatar Jul 26 '22 20:07 runspired

tbh we should probably just eliminate that portion of the check anyway, we won't ever de-activate rollup and when we move to a v2-addon setup it'll still use rollup. It is useful though for understanding what modules are cost centers for the library as a whole.

runspired avatar Jul 26 '22 20:07 runspired

fixed in https://github.com/emberjs/data/commit/c95c56a8c909b2767c49093d55019df0c2c891dd

runspired avatar Aug 29 '22 21:08 runspired