data icon indicating copy to clipboard operation
data copied to clipboard

Model.eachTransformedAttribute not under test coverage / broken 3.28+

Open runspired opened this issue 2 years ago • 2 comments

Recently discovered that this method was implemented incorrectly on ShimModelClass which is what we began handing out to adapters/serializers in 3.28. This means starting in 3.28+ transforms would not have been applied correctly during normalization.

I've fixed this on the typescript branch (thank you typescript for surfacing!) but we should port a fix to 3.28 / release and also add some tests.

runspired avatar Apr 21 '22 04:04 runspired

Hey @runspired, I don’t mind taking a look at this one. What is the name of the typescript branch?

geneukum avatar May 05 '22 13:05 geneukum

@geneukum https://github.com/emberjs/data/pull/7957

runspired avatar May 06 '22 02:05 runspired