data icon indicating copy to clipboard operation
data copied to clipboard

Handle empty query params properly by allowing in the url

Open snewcomer opened this issue 3 years ago • 3 comments

https://jsonapi.org/format/#fetching-sparse-fieldsets

An empty value indicates that no fields should be returned.

The JSONAPI has taken a strict stance on what an empty query param should mean. They stated it should return no fields instead of leaving it up to the implementer. I think we should follow.

Original PR that strips falsey values: https://github.com/emberjs/data/pull/6077/files. We need to keep the query param so that an API can know that, for example, no rows are returned if ids=[].

Ref implementation in other areas: https://github.com/jeregrine/jsonapi/pull/257

close #7720

snewcomer avatar Oct 17 '21 03:10 snewcomer

Asset Size Report for dfabd6a3cc09089e25ca85c4c95c5393341ee31e

Modern Builds

EmberData increased by -21.0 B (-30.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/adapter has increased by +21.0 B.

Changeset


EmberData +185.81 KB +21.0 B (+39.5 KB -30.0 B compressed)
    @ember-data/adapter +15.88 KB +21.0 B (+3.38 KB -30.0 B compressed)
        @ember-data/adapter/-private +3.83 KB +21.0 B (+833.6 B -30.0 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '185.81 KB' │
│ compressed │ '39.50 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '78.11 KB' │
│  compressed  │ '16.61 KB' │
│ % Of Library │   '42.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 77.20 KB  | 16.41 KB   | 98.8          | 41.5
	@ember-data/store/index                           | 936.00 B  | 198.99 B   | 1.2           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '29.11 KB' │
│  compressed  │ '6.19 KB'  │
│ % Of Library │   '15.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.64 KB  | 6.09 KB    | 98.4          | 15.4
	@ember-data/model/index                           | 486.00 B  | 103.32 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.07 KB' │
│  compressed  │ '5.12 KB'  │
│ % Of Library │   '13.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.07 KB  | 5.12 KB    | 100.0         | 13.0

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.74 KB' │
│  compressed  │ '4.20 KB'  │
│ % Of Library │   '10.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.21 KB   | 1.53 KB    | 36.5          | 3.9
	@ember-data/serializer/-private                   | 5.52 KB   | 1.17 KB    | 28.0          | 3.0
	@ember-data/serializer/json-api                   | 3.75 KB   | 815.96 B   | 19.0          | 2.0
	@ember-data/serializer/rest                       | 2.80 KB   | 608.67 B   | 14.2          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 54.85 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 45.70 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.88 KB' │
│  compressed  │ '3.38 KB'  │
│ % Of Library │   '8.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.99 KB   | 1.70 KB    | 50.3          | 4.3
	@ember-data/adapter/-private                      | 3.83 KB   | 833.60 B   | 24.1          | 2.1
	@ember-data/adapter/error                         | 1.99 KB   | 433.49 B   | 12.5          | 1.1
	@ember-data/adapter/index                         | 1.04 KB   | 225.56 B   | 6.5           | 0.6
	@ember-data/adapter/json-api                      | 1.03 KB   | 225.14 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.35 KB' │
│  compressed  │ '1.99 KB' │
│ % Of Library │   '5.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 526.39 B   | 25.9          | 1.3
	ember-data/-private                               | 2.13 KB   | 463.04 B   | 22.8          | 1.1
	ember-data/adapters/errors                        | 1.19 KB   | 258.73 B   | 12.7          | 0.6
	ember-data/setup-container                        | 368.00 B  | 78.23 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.60 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.25 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 53.36 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.08 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.66 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.66 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.23 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.38 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.32 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.04 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.19 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.19 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.34 B    | 2.3           | 0.1
	ember-data/version                                | 161.00 B  | 34.22 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.43 KB' │
│ % Of Library │   '3.6'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 655.23 B   | 44.7          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 345.90 B   | 23.6          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 100.13 B   | 6.8           | 0.2
	ember-inflector/index                             | 379.00 B  | 80.57 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 79.30 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 74.83 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.60 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.92 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '613.14 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 505.77 B   | 82.5          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 107.36 B   | 17.5          | 0.3

Modern Builds (No Rollup)

EmberData increased by -21.0 B (-13.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/adapter has increased by +21.0 B.

Changeset


EmberData +225.12 KB +21.0 B (+42.67 KB -13.0 B compressed)
    @ember-data/adapter +18.0 KB +21.0 B (+3.41 KB -13.0 B compressed)
        @ember-data/adapter/-private/utils/serialize-query-params +811.0 B +21.0 B (+153.7 B -13.0 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '225.12 KB' │
│ compressed │ '42.67 KB'  │
│  packages  │      8      │
│  modules   │     148     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬─────────────┐
│   (index)    │   Values    │
├──────────────┼─────────────┤
│    bytes     │ '101.56 KB' │
│  compressed  │ '19.25 KB'  │
│ % Of Library │   '45.1'    │
└──────────────┴─────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.26 KB  | 3.27 KB    | 17.0          | 7.7
	@ember-data/store/-private/system/model/internal-model                             | 14.72 KB  | 2.79 KB    | 14.5          | 6.5
	@ember-data/store/-private/system/model/states                                     | 5.49 KB   | 1.04 KB    | 5.4           | 2.4
	@ember-data/store/-private/system/fetch-manager                                    | 5.21 KB   | 1011.29 B  | 5.1           | 2.3
	@ember-data/store/-private/system/record-array-manager                             | 4.34 KB   | 842.23 B   | 4.3           | 1.9
	@ember-data/store/-private/system/store/finders                                    | 4.00 KB   | 776.47 B   | 3.9           | 1.8
	@ember-data/store/-private/identifiers/cache                                       | 3.95 KB   | 766.04 B   | 3.9           | 1.8
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.46 KB   | 671.09 B   | 3.4           | 1.5
	@ember-data/store/-private/index                                                   | 3.36 KB   | 652.14 B   | 3.3           | 1.5
	@ember-data/store/-private/system/references/has-many                              | 3.23 KB   | 627.31 B   | 3.2           | 1.4
	@ember-data/store/-private/system/snapshot                                         | 3.09 KB   | 599.26 B   | 3.0           | 1.4
	@ember-data/store/-private/system/references/belongs-to                            | 2.89 KB   | 560.98 B   | 2.8           | 1.3
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.88 KB   | 559.84 B   | 2.8           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.29 KB   | 444.05 B   | 2.3           | 1.0
	@ember-data/store/-private/system/references/record                                | 2.02 KB   | 392.12 B   | 2.0           | 0.9
	@ember-data/store/-private/system/ds-model-store                                   | 1.92 KB   | 373.54 B   | 1.9           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.79 KB   | 346.82 B   | 1.8           | 0.8
	@ember-data/store/-private/system/schema-definition-service                        | 1.52 KB   | 294.32 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 256.04 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 221.36 B   | 1.1           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 999.00 B  | 189.33 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 177.39 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 931.00 B  | 176.44 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 916.00 B  | 173.60 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 167.91 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 802.00 B  | 151.99 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 800.00 B  | 151.61 B   | 0.8           | 0.3
	@ember-data/store/-private/system/snapshot-record-array                            | 769.00 B  | 145.74 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 699.00 B  | 132.47 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 609.00 B  | 115.41 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 604.00 B  | 114.47 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 113.33 B   | 0.6           | 0.3
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 93.62 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.29 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 454.00 B  | 86.04 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 392.00 B  | 74.29 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 348.00 B  | 65.95 B    | 0.3           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 329.00 B  | 62.35 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 59.88 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 54.96 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 271.00 B  | 51.36 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 48.70 B    | 0.2           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.69 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.17 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 39.79 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.02 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 31.65 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.46 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.46 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.46 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.51 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.32 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.32 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.56 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.56 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 28.80 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.23 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 27.67 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 27.67 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '33.20 KB' │
│  compressed  │ '6.29 KB'  │
│ % Of Library │   '14.7'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 10.08 KB  | 1.91 KB    | 30.4          | 4.5
	@ember-data/model/-private/record-state                               | 6.23 KB   | 1.18 KB    | 18.8          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.95 KB   | 766.04 B   | 11.9          | 1.8
	@ember-data/model/-private/system/many-array                          | 2.86 KB   | 554.54 B   | 8.6           | 1.3
	@ember-data/model/-private/errors                                     | 2.10 KB   | 407.47 B   | 6.3           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 275.94 B   | 4.3           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.31 KB   | 253.39 B   | 3.9           | 0.6
	@ember-data/model/-private/attr                                       | 874.00 B  | 165.64 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 160.14 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 688.00 B  | 130.39 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 122.81 B   | 1.9           | 0.3
	@ember-data/model/-private/util                                       | 526.00 B  | 99.68 B    | 1.5           | 0.2
	@ember-data/model/index                                               | 486.00 B  | 92.10 B    | 1.4           | 0.2
	@ember-data/model/-private/system/diff-array                          | 452.00 B  | 85.66 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 84.71 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 80.92 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '31.14 KB' │
│  compressed  │ '5.90 KB'  │
│ % Of Library │   '13.8'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.29 KB   | 1.57 KB    | 26.6          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.93 KB   | 956.89 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.15 KB   | 611.01 B   | 10.1          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.87 KB   | 557.19 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.04 KB   | 395.15 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.94 KB   | 376.01 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 293.19 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.06 KB   | 205.63 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/-utils                                     | 1.06 KB   | 204.87 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 185.16 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 798.00 B  | 151.23 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 131.14 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 677.00 B  | 128.30 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 76.94 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.52 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.10 B    | 0.7           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.40 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.42 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.16 KB' │
│  compressed  │ '4.20 KB'  │
│ % Of Library │   '9.8'    │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.21 KB   | 1.37 KB    | 32.6          | 3.2
	@ember-data/serializer/-private/embedded-records-mixin     | 4.41 KB   | 856.07 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.75 KB   | 727.38 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.80 KB   | 542.60 B   | 12.6          | 1.2
	@ember-data/serializer/-private/index                      | 1.18 KB   | 229.32 B   | 5.3           | 0.5
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 100.44 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 511.00 B  | 96.84 B    | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/number          | 453.00 B  | 85.85 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 381.00 B  | 72.20 B    | 1.7           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 57.42 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 48.89 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 42.83 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.74 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.00 KB' │
│  compressed  │ '3.41 KB'  │
│ % Of Library │   '8.0'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.99 KB   | 1.51 KB    | 44.4          | 3.5
	@ember-data/adapter/error                                     | 1.99 KB   | 386.43 B   | 11.1          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 375.25 B   | 10.7          | 0.9
	@ember-data/adapter/index                                     | 1.04 KB   | 201.08 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.03 KB   | 200.70 B   | 5.7           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 200.13 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 811.00 B  | 153.70 B   | 4.4           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 568.00 B  | 107.64 B   | 3.1           | 0.2
	@ember-data/adapter/-private/utils/parse-response-headers     | 494.00 B  | 93.62 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 86.04 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 367.00 B  | 69.55 B    | 2.0           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.07 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 27.85 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.51 KB' │
│  compressed  │ '1.80 KB' │
│ % Of Library │   '4.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 469.25 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 374.11 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 230.64 B   | 12.5          | 0.5
	ember-data/-private/core                          | 368.00 B  | 69.74 B    | 3.8           | 0.2
	ember-data/setup-container                        | 368.00 B  | 69.74 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.26 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 51.92 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.56 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.43 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.05 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.05 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.67 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 44.91 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 43.96 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 42.83 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.07 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.07 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.31 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 30.51 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 584.10 B   | 44.7          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 308.35 B   | 23.6          | 0.7
	ember-inflector/lib/system                        | 471.00 B  | 89.26 B    | 6.8           | 0.2
	ember-inflector/index                             | 379.00 B  | 71.82 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 70.69 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 66.71 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.26 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.09 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '546.58 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 450.87 B   | 82.5          | 1.0
	@ember-data/debug/setup                           | 505.00 B  | 95.70 B    | 17.5          | 0.2

github-actions[bot] avatar Oct 17 '21 03:10 github-actions[bot]

Performance Report for dfabd6a3cc09089e25ca85c4c95c5393341ee31e

Scenario - materialization: ☑️ Performance is stable

☑️ duration phase no difference [-15ms to 18ms] ☑️ Phase [navigationStart] => [start-find-all] phase no difference [-9ms to 5ms] ☑️ Phase [start-find-all] => [start-materialization] phase no difference [-6ms to 11ms] ☑️ Phase [start-materialization] => [end-materialization] phase no difference [-4ms to 4ms] ☑️ Phase [end-materialization] => [Test End] phase no difference [-5ms to 3ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration phase no difference [-13ms to 14ms] ☑️ Phase [navigationStart] => [start-push-payload] phase no difference [-16ms to 2ms] ☑️ Phase [start-push-payload] => [start-unload-records] phase no difference [-2ms to 18ms] ☑️ Phase [start-unload-records] => [end-unload-records] phase no difference [-2ms to 1ms] ☑️ Phase [end-unload-records] => [Test End] phase no difference [0ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration phase no difference [-35ms to 9ms] ☑️ Phase [navigationStart] => [start-push-payload] phase no difference [-20ms to 2ms] ☑️ Phase [start-push-payload] => [start-destroy-records] phase no difference [-22ms to 10ms] ☑️ Phase [start-destroy-records] => [end-destroy-records] phase no difference [-6ms to 5ms] ☑️ Phase [end-destroy-records] => [Test End] phase no difference [0ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration phase no difference [-25ms to 26ms] ☑️ Phase [navigationStart] => [start-push-initial-payload] phase no difference [-8ms to 16ms] ☑️ Phase [start-push-initial-payload] => [start-push-update-payload] phase no difference [-16ms to 13ms] ☑️ Phase [start-push-update-payload] => [end-push-update-payload] phase no difference [-6ms to 4ms] ☑️ Phase [end-push-update-payload] => [Test End] phase no difference [-2ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration phase no difference [-23ms to 35ms] ☑️ Phase [navigationStart] => [start-push-payload] phase no difference [-11ms to 10ms] ☑️ Phase [start-push-payload] => [end-push-payload] phase no difference [-18ms to 26ms] ☑️ Phase [end-push-payload] => [Test End] phase no difference [-2ms to 2ms]

github-actions[bot] avatar Oct 17 '21 03:10 github-actions[bot]

Reviewed with @snewcomer, decided to limit this just to json-api adapter

igorT avatar Nov 04 '21 22:11 igorT

Closing as this has gone stale and we're moving away from adapters. The request utils / request-manager do not exhibit this issue.

runspired avatar Sep 03 '23 22:09 runspired