data icon indicating copy to clipboard operation
data copied to clipboard

Published 20 hours ago • verified publisher icon emberjs

Failing test for unloadAll scenario with hasMany relationship that ends up wrong

Open lukemelia opened this issue 6 years ago • 3 comments

This is a simplified failing test for an issue we experienced in our app.

The test passes when an optimization is commented out, specifically the conditional here: https://github.com/emberjs/data/blob/ece04949ecfd84c491490dd9a110e02d2ff0afa4/addon/-legacy-private/system/relationships/state/relationship.js#L304

We're happy to work on a fix but are not sure where to go from here.

  • @lukemelia & @jasonbekolay

lukemelia avatar Aug 17 '18 20:08 lukemelia

@lukemelia thanks! I'll investigate what the next step is

runspired avatar Aug 20 '18 16:08 runspired

Cool @runspired. FWIW, we decided to temporarily run with a fork that has the optimization line I referenced commented out.

lukemelia avatar Aug 21 '18 03:08 lukemelia

@lukemelia any chance you got stuck here at some point? I doubt this is still a bug but if it is happy to get the test caught up and a fix investigated. Because of the way the relationship layer and unload works today this test probably isn't a meaningful addition anymore unless there's still a known issue it manages to catch

runspired avatar Sep 02 '22 08:09 runspired