ember-template-lint icon indicating copy to clipboard operation
ember-template-lint copied to clipboard

Request: show todo count

Open MelSumner opened this issue 3 years ago • 5 comments

When I use the --include-todo flag, it shows me all of the todos in my cli as well as showing me the final count, e.g. ✖ 4360 problems (0 errors, 162 warnings, 4198 todos)

However, if I just run yarn lint:hbs I get errors and warnings, but not todos (even if they exist): ✖ 162 problems (0 errors, 162 warnings)

I would like the CLI to always show me the todo count the same way it shows me the errors and the warning counts. Alternatively, a different command that includes todo counts w/o printing the todos to the console the way --include-todo does.

MelSumner avatar Mar 11 '21 20:03 MelSumner

Looks like it's already counted, may be an regression, or corner-case image

lifeart avatar Mar 17 '21 11:03 lifeart

image

lifeart avatar Mar 17 '21 11:03 lifeart

I think it's working as intended right now; I'm asking for a change to the intention.

MelSumner avatar Mar 17 '21 16:03 MelSumner

Ya we discussed this before. We can totally make this change. Curious what others think.

scalvert avatar Mar 17 '21 17:03 scalvert

Here is what I think we should do:

  • stdout should be empty when running without issue for non-interactive shells

  • When we are already going to print the console status line (e.g. when we have errors or warnings to report) we should include the number of todos

  • Aside from those cases (e.g. interactive shells without warnings or errors), we should emit a single console line with the number of todos. I feel less strongly about this part, but seems fairly nice (and a quick reminder of those pending todos).

rwjblue avatar Mar 18 '21 02:03 rwjblue