ember-cli-template-lint icon indicating copy to clipboard operation
ember-cli-template-lint copied to clipboard

Support Many Kinds of Projects

Open jherdman opened this issue 5 years ago • 1 comments

Resolves #381

So, there are two problems with this PR as I see it:

  • [ ] I don't have tests for addons
  • [ ] I don't have tests for an MU project

I'm a little uncertain how to do this. I have, however, tested this in an addon of my own and can see that it works.

jherdman avatar Sep 13 '18 03:09 jherdman

Tried this PR to generate the "pending" for an addon and I encountered an issue where

let moreFiles = this._scanForHbsFiles('tests/dummy/app');

Would return:

[ 'templates/application.hbs' ]

Then later in the processing it would complains about:

ENOENT: no such file or directory, open 'addon/templates/application.hbs'

There are no application.hbs in addon so it looks like it took addon directory as root for templates resolved in tests.

Edit:

This is caused by scanForFiles using a different root than apptRoot and run() appending appRoot to all resolved templates files.

panthony avatar Dec 31 '18 14:12 panthony