Documentation and code do not agree on runDisposables
According to the code, runDisposables is deprecated and is not required anymore. This clashes with the documentation where it strongly recommends to use the method. I assume that the documentation needs updating to reflect the new situation in the code.
I assume that the documentation needs updating to reflect the new situation in the code.
Yep! We missed updating that when we removed that requirement.
Does the docs site need updating/regenerating somehow with recent changes (as per #978)?
https://ember-lifeline.github.io/ember-lifeline/versions/master/ currently crashes and I'm not sure where else in the project to look.
https://ember-lifeline.github.io/ember-lifeline/docs
Still incorrectly(?) says to use runDisposables()
--- from website:
Using ember-lifeline's equivalent, in this case runTask, can help ensure that any active async is cleaned up once the object is destroyed.
import Component from '@ember/component';
import { runTask, runDisposables } from 'ember-lifeline';
export default Component.extend({
init() {
this._super(...arguments);
runTask(
this,
() => {
this.set('date', new Date());
},
500
);
},
willDestroy() {
this._super(...arguments);
runDisposables(this);
},
});
Yep, I haven't updated the docs site yet. I've been a bit busy. I'll try to get to it soon.
Still appears to be incorrect in the readme