super-rentals-tutorial icon indicating copy to clipboard operation
super-rentals-tutorial copied to clipboard

update node version to 16 for ember-beta

Open mansona opened this issue 2 years ago • 2 comments

Since ember-cli@5 requires a minimum of Node@16 I have updated that in our volta pin 👍

mansona avatar Apr 07 '23 13:04 mansona

So I think I need a bit of help to continue with this one. For some reason the git diff isn't applying in the CI environment but it is applying properly locally 🤔

I thought it might be an issue with a difference between my git version locally and the one in the github actions but I tried updating both and it didn't seem to do anything 😞

One thing that I noticed is that the git diff looked a bit odd locally, it had some extra stuff that looked like it shouldn't be there.

@@ -9,2 +9,3 @@ module.exports = function (environment) {
     EmberENV: {
+      RAISE_ON_DEPRECATION: true,
       FEATURES: {

The module.exports = function (environment) { seems out of place in that patch 🤔 and sure enough if I left that it would fail locally. But I think I tried leaving it in and it still failied on the CI 😞

Any help here would be much appreciated 🎉

mansona avatar Apr 07 '23 14:04 mansona

#227 pulled in your node update -- did you want to land any of the other changes in this PR or should it be closed?

kategengler avatar Jun 21 '23 04:06 kategengler