guides-source icon indicating copy to clipboard operation
guides-source copied to clipboard

Remove outdated / incorrect information on the initializers page

Open NullVoxPopuli opened this issue 7 months ago • 3 comments

implicit injections were deprecated long ago

NullVoxPopuli avatar Apr 25 '25 18:04 NullVoxPopuli

Deploy Preview for ember-guides ready!

Name Link
Latest commit 059f852bff813a3230c44a217866b032166f15be
Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/680bd4975665d10008c685fa
Deploy Preview https://deploy-preview-2108--ember-guides.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Apr 25 '25 18:04 netlify[bot]

@NullVoxPopuli the implicit injection part of this is outdated, perhaps, but are Application Initializers and Application Instance Initializers themselves deprecated?

I'm asking since I'm reporting ember deprecations to @sentry/ember, and there I also see they are using an instance initializer for sentry-performance.

Thanks,

johanrd avatar Jun 10 '25 19:06 johanrd

but are Application Initializers and Application Instance Initializers themselves deprecated?

they are not

also see they are using an

that is fine :tada:

NullVoxPopuli avatar Jun 10 '25 20:06 NullVoxPopuli

While this does remove the outdated service injections, it makes the page incomplete about initializers itself. We could replace the injection bit with a different setup logic as example instead?

IgnaceMaes avatar Jun 23 '25 13:06 IgnaceMaes

sure, but I don't have the energy to write that rn. <3

NullVoxPopuli avatar Jun 23 '25 13:06 NullVoxPopuli

I would rather have incomplete docs than totally misleading ones :see_no_evil:

https://discord.com/channels/480462759797063690/480777444203429888/1386696245149434009

NullVoxPopuli avatar Jun 23 '25 13:06 NullVoxPopuli