guides-source icon indicating copy to clipboard operation
guides-source copied to clipboard

Guides seem broken due to TypeError

Open amyrlam opened this issue 3 years ago • 10 comments

Visit https://guides.emberjs.com/release/testing/

IS: image

Will crosspost in Discord #dev-ember-learning

amyrlam avatar Dec 22 '21 22:12 amyrlam

Some more info:

  • If I Google "Ember acceptance tests", the first link on Google takes me to 2.14. Strange behavior, ideally would always go to the latest.
  • When I go from 2.14 to 4.0, the blank UI I saw in the screenshot above flashes, then goes away. I can't reliably reproduce it...not 100% certain how I got that before. Once I got the above screenshot, every guides page was borked.
  • If I try to use the back button, I'm 404'd.

Hope this helps, sorry not more time to dig into it right now!

ember-guides

amyrlam avatar Dec 23 '21 02:12 amyrlam

The top Google search result is a pretty common problem for versioned materials like this. Unfortunately, it is something that we (and anyone like us, writing docs) have very little control over. You will see the same thing searching versions docs for just about anything – I hit it today, for example, with the music notation software I use (Dorico).

chriskrycho avatar Dec 23 '21 02:12 chriskrycho

Thanks for reporting. I’m glad things aren’t broken across the board. I think I have seen this when the back/next links at the bottom break. If that’s the case, we need a fallback behavior added to guidemaker.

jenweber avatar Dec 23 '21 15:12 jenweber

Data point here is we renamed the link: https://guides.emberjs.com/release/testing/testing-application/ vs https://guides.emberjs.com/v2.14.0/testing/acceptance/

chrisrng avatar Dec 23 '21 16:12 chrisrng

I'm guessing this is somewhere in guidemaker. Do you have an idea where we can start poking @mansona?

locks avatar Dec 23 '21 16:12 locks

If a changed URL is part of the problem, perhaps what we need is to backfill a missing redirect.

jenweber avatar Dec 23 '21 18:12 jenweber

@jenweber I think it is more insidious than that, see the browser URL and the URL in the GET request in the followinig screenshot:

Screenshot of guides.emberjs.com showing a 404 error in the Network tab of the developer tools

locks avatar Dec 23 '21 19:12 locks

Dug into this a bit. Looks like the redirect is being cached when doing browser back, I'm not super familiar with the guidemaker but its not in the payload (http://localhost:4200/content/v2.14.0/testing/acceptance.json) but it is in the model response.

chrisrng avatar Dec 23 '21 20:12 chrisrng

still a problem :C

locks avatar Jan 24 '22 21:01 locks

Yup.

locks avatar Jul 25 '23 00:07 locks