guides-source icon indicating copy to clipboard operation
guides-source copied to clipboard

ember serve vs. yarn/npm run start

Open samselikoff opened this issue 5 years ago • 4 comments

Just a small inconsistency. The quickstart says

cd ember-quickstart
ember serve

but my terminal showed

👉   We suggest you that you get started by typing:

$ cd ember-quickstart
$ yarn start

Also the language "We suggest you that you get started by typing" has a typo and (I think) could be more direct! Maybe "Get started by typing:"

samselikoff avatar Oct 08 '19 03:10 samselikoff

Thanks for reporting!

We suggest you that you get started by typing:

This message is printed by ember-cli itself.

@dcyriller - Have any cycles to poke at this? I think it would also target the release branch of ember-cli...

rwjblue avatar Oct 08 '19 21:10 rwjblue

You're right, "Get started by tying" is better (https://github.com/ember-cli/ember-cli/pull/8882).

That said, can I argue for yarn start over ember serve? 😉

Running ember serve implies ember-cli is installed globally. Instead yarn start (or npm start) executes ember-cli project's version.

Globally installed packages tend to be outdated very fast. Should we not reference local usage over the global one whenever it is possible?

I have no idea how changes are made to the guides. Should the suggestion to change ember serve by yarn start be discussed? Or opening a PR for is fine?

Depending on your answers, I'll update my ember-cli PR to change yarn start to ember serve / open a PR against the guides to make the opposite change.

dcyriller avatar Oct 09 '19 09:10 dcyriller

Please forget about my previous comment. I won't have time / focus to do what I suggest.

The ember-cli PR is updated with ember serve.

dcyriller avatar Oct 09 '19 12:10 dcyriller

That said, can I argue for yarn start over ember serve? 😉

Ya, I definitely agree with you here.

rwjblue avatar Oct 09 '19 18:10 rwjblue