ember-website
ember-website copied to clipboard
Begin support for translations
Implementation prompted by: https://github.com/ember-learn/ember-website/issues/901
This will enable users:
- to switch to their preferred language
- help translate to their preferred language
- not need to worry about the technical details of how to setup ember-intl
Non-goals:
- actually do translations for non-english (PRs very welcome for that)
Open for discussion:
- keep everything in git? or lean on something like CrowdIn? (or other translation service?)
- I think CrowdIn has an embeddable widget to allow folks to translate without interacting with code
- I can set this up and own it if folks want to see how it works / a demo, etc
- I think CrowdIn has an embeddable widget to allow folks to translate without interacting with code
Remaining Requirements:
- [ ] need to lessen the barrier to contribution / translation submission (potentially via in-site widget)
- [ ] need to have a way to display when translations are out of date on a specific page (most useful for the guides)
- [ ] need to polish up the language switcher
Developing:
- locally, there will be "missing translation" errors", but in production a fallback of english is configured
Notes on the PR:
- translation switcher needs work, what is in this PR is the bare minimum to demonstrate the functionality
- sample translations are from google translate, so, we'll see if native speakers agree with a machine or not 🙃 (not required for merging, but just demonstration in this PR)
✔️ Deploy Preview for ember-website ready!
🔨 Explore the source changes: 07b3bccc575bd9b17d438bc08230f4fa8f1f603e
🔍 Inspect the deploy log: https://app.netlify.com/sites/ember-website/deploys/621272c5038f360008017dcc
😎 Browse the preview: https://deploy-preview-902--ember-website.netlify.app
This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks!
stalebot is hostile to long-running work. shoo. lol
This pull request has been automatically marked stale. If this pull request is something that still needs work, please add a comment and it will remain open, otherwise it will close in 7 days. You are welcome to open a new pull request if you miss the window. Thanks!
Rude, bot