ember-website icon indicating copy to clipboard operation
ember-website copied to clipboard

Add /logos/ route new sections and anchor links

Open samridhivig opened this issue 1 year ago • 4 comments

This MR works on the Copy/Content Updates to /logos/ page #1007 issue tasks:

  1. Each section has an ID that can be used in the anchor link in order to navigate to a specific section
  2. Added id to each Mascot ListItem li i.e mascot.id
  3. Added the necessary sections
  4. Added links to each instance of the Standard Art Set
  5. Added the links to the mascot items specified in Standard Art Set

samridhivig avatar Apr 14 '23 00:04 samridhivig

Deploy Preview for ember-website ready!

Name Link
Latest commit dc5c442184cd5b272b3e1ab0d6a10604765c9cdd
Latest deploy log https://app.netlify.com/sites/ember-website/deploys/643e94f61d534f0008d8507b
Deploy Preview https://deploy-preview-1009--ember-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Apr 14 '23 00:04 netlify[bot]

It looks like the anchors on the Mascots aren't working. If you follow the new links on the Brand page, the URL is updating, but the mascots page jumps back to the top. Just me?

This looks otherwise amazing, thank you @samridhivig so much for doing the work, and sorry I've been offline and haven't said that sooner!

wifelette avatar Apr 23 '23 23:04 wifelette

Same here, in the preview and running it locally ;) I'll check at the learning meeting if somebody there knows why.

MinThaMie avatar Apr 24 '23 12:04 MinThaMie

So this came up a long time ago when I tried to implement the same thing. The issue is that we need to enable an experimental feature on Fastboot that will allow this to work as expected 🙈 (It's EXPERIMENTAL_RENDER_MODE_SERIALIZE for reference)

We discussed this in the Learning team today and we think it's probably best to update this PR to not include the links to the specific Tomsters/Zoes and we can fix the linking problem in a different PR. Essentially we're not 100% comfortable enabling the experimental feature without testing it and we didn't want to block the other important bits of this PR.

What do you think?

mansona avatar Apr 24 '23 16:04 mansona