ember-help-wanted icon indicating copy to clipboard operation
ember-help-wanted copied to clipboard

Published 20 hours ago • verified publisher icon ember-learn

Apply latest styleguide version

Open jenweber opened this issue 5 years ago • 3 comments

Things that need fixing:

  • [ ] buttons are too large and the styleguide size variations did not seem to work (note that we are using the link form of the button by applying classes to <a> (screenshot 1)
  • [ ] double ember logos look weird (screenshot 1)
  • [ ] Is it a design choice that cards do not have shadows? We kept the shadows, could tighten them up more
  • [ ] need some normalizing rules for tables, especially to make th not so bold
  • [ ] need an "active" state for the buttons
  • [ ] should use the small button style for "search" once it is fixed
Screen Shot 2019-11-16 at 2 45 55 PM

jenweber avatar Nov 16 '19 19:11 jenweber

I am on it

vinodhrajamuralidharan avatar Mar 20 '20 20:03 vinodhrajamuralidharan

Hi @vinodhrajamuralidharan Thanks so much for the help! You can start your work from the website-redesign-rfc branch. The very first thing to do is to update the version of the styleguide to the latest release, in package.json. Then, see if things still look ok and what else needs fixing. The Styleguide has changed significantly since that branch was first created.

You can see the latest Styleguide docs here: https://deploy-preview-145--ember-styleguide.netlify.com/ This URL will disappear once https://github.com/ember-learn/ember-styleguide/pull/145 is merged.

jenweber avatar Mar 20 '20 21:03 jenweber

@vinodhrajamuralidharan please DM me on Discord if you need help with anything- thank you for taking it on! 👍

MelSumner avatar Mar 27 '20 16:03 MelSumner