Write missing deprecation guides

[locks]

Hi everyone!

We noticed some missing deprecation guides when doing housekeeping in preparation for 4.0. Assign yourself one of the deprecations below and let's get this done :)

What to do

• Add a new deprecation. You can consult the relevant RFC to get a good idea of what the guide should contain.
• Update the relevant source code (also linked below) with a link to the deprecation. You can get a deprecation link using the netlify preview. Asks us if you need help!
• Boom, you're done!

Deprecations

Ember.Component.reopen

• id: ember.component.reopen
• rfc: https://emberjs.github.io/rfcs/0671-modernize-built-in-components-1.html?highlight=reopening#reopening-classic-component-super-class
• source: https://github.com/emberjs/ember.js/blob/9609b8f30e0cdbc2235063f571af619f4362f73b/packages/@ember/-internals/glimmer/lib/component.ts#L1156
• assignee: @Glarregle
• Status: deprecation guide merged, waiting on merging the source code PR

Passing tagName to LinkTo

• id: ember.link-to.tag-name
• rfc: https://emberjs.github.io/rfcs/0707-modernize-built-in-components-2.html
• source: https://github.com/emberjs/ember.js/blob/57907a4d7d91aa58b3b3ac1258e639ce221f9492/packages/@ember/-internals/glimmer/lib/components/link-to.ts#L432
• Status - deprecation guide exists: https://github.com/ember-learn/deprecation-app/issues/893 PR to update source code https://github.com/emberjs/ember.js/pull/19747

Passing disabledWhen to LinkTo

• id: ember.link-to.disabled-when
• rfc: https://emberjs.github.io/rfcs/0707-modernize-built-in-components-2.html
• source: https://github.com/emberjs/ember.js/blob/57907a4d7d91aa58b3b3ac1258e639ce221f9492/packages/@ember/-internals/glimmer/lib/components/link-to.ts#L627
• assignee: @Glarregle

Old deprecate method imports

• id: old-deprecate-method-paths
• rfc: https://emberjs.github.io/rfcs/0176-javascript-module-api.html
• source: https://github.com/emberjs/ember.js/blob/22bfcfdac0aeefcf333fb2d6697772934201b43b/packages/@ember/application/deprecations.ts#L8
• assignee: @Glarregle

Deprecate without for

• id: ember-source-deprecation-without-for
• rfc: https://emberjs.github.io/rfcs/0649-deprecation-staging.html#deprecate
• source: https://github.com/emberjs/ember.js/blob/4984045459bc9f5f34f1ae8b51fc6522fb72cbf4/packages/@ember/debug/lib/deprecate.ts#L211
• assignee: @bartocc, @fannyvanrell

Deprecate without since

• id: ember-source-deprecation-without-since
• rfc: https://emberjs.github.io/rfcs/0649-deprecation-staging.html#deprecate
• source: https://github.com/emberjs/ember.js/blob/4984045459bc9f5f34f1ae8b51fc6522fb72cbf4/packages/@ember/debug/lib/deprecate.ts#L224
• assignee: @bartocc, @fannyvanrell

EXTEND_PROTOTYPES

• id: ember-env.old-extend-prototypes
• rfc:
• source: https://github.com/emberjs/ember.js/blob/566af4941eb7ecaa4679e295ecfc38263d5ee1fe/packages/ember/index.js#L175
• assignee: @bartocc, @fannyvanrell

Class-based template compilation plugins

• id: template-compiler.registerPlugin
• rfc:
• source: https://github.com/emberjs/ember.js/blob/e28a201b9ccfb16f93089cea9207fca9b552d98c/packages/ember-template-compiler/lib/system/compile-options.ts#L93
• assignee: -- Need Help --

[ef4]

I think also deprecated-run-loop-and-computed-dot-access.

[chancancode]

That’s correct. In practice it can probably share most of the prose with that globals deprecation, you mostly experience that as a special case of the globals access deprecation

[Glarregle]

I will work on the following:

Ember.Component.reopen Passing tagName to LinkTo Passing disabledWhen to LinkTo Old deprecate method imports

[ijlee2]

@Glarregle Awesome, thank you!

[jenweber]

I have a PR open that creates placeholder files for all these deprecations. We still need volunteers to fill in all the details in each deprecation guide. See https://github.com/ember-learn/deprecation-app/pull/954

@Glarregle if my PR is merged before yours, please feel free to delete any of my descriptions and fill them with your own writeup. All I did was make the files and copy-paste the deprecation message into them, and we want to provide better guidance than what I copied in. Thank you!

[jenweber]

@Glarregle I discovered that the tagName deprecation already exists: https://deprecations.emberjs.com/v3.x/#toc_ember-built-in-components-legacy-arguments so this one does not need a new writeup.

[bartocc]

Hi, @fannyvanrell and myself would like to work on EXTEND_PROTOTYPES if that's still needed.

cc: @monsieurdart @pbernery

[ijlee2]

@bartocc @fannyvanrell Thank you, I think we do need help with providing details for https://deprecations.emberjs.com/v3.x#toc_ember-env-old-extend-prototypes.

Can you also fix the typo in the h3 header? protptypes should read prototypes.

[bartocc]

Hi again. We'd like to go for Deprecate without for and Deprecate without since if that's OK. cc @fannyvanrell

[ijlee2]

@bartocc @fannyvanrell I updated the description to list your names.