Run a11y test over deprecation-app

[serenaf]

See https://github.com/ember-learn/guides-app/issues/46 as example and follow ;)

[takshch]

This issue is too old. Is this issue still exits? If yes, assign me to this issue.

[ijlee2]

Hi, @takshch. Thanks for taking an interest in helping out. I think it's a good idea to audit accessibility in tests. However, there are currently 2 soft-blocking issues.

One, installing ember-a11y-testing v4 will result in an error,

ember-a11y-testing has the following unmet peerDependencies:
  * @ember/test-helpers: `^2.0.0`; it was resolved to `1.7.2`

because ember-qunit v4.6 still uses version 1.x of @ember/test-helpers. We could install v3.x of ember-a11y-testing to see how much work will be needed in fixing a11y issues (when visiting the pages listed in https://github.com/ember-learn/deprecation-app/blob/master/tests/acceptance/visual-regression-test.js#L10).

Two, the app may be redesigned some time in the future so the work that you may put into may be gone. If there's a lot of work needed in fixing a11y issues, I think it may not be a good idea to make big changes to the app right now.

Before we decide whether to continue with this issue, I'd like to hear what your thoughts are on these two matters. Thanks again!

[MinThaMie]

Close this for now, because we need to come up with a strategy for this topic across all our learning repos :)