ember-apollo-client icon indicating copy to clipboard operation
ember-apollo-client copied to clipboard

Published 20 hours ago • verified publisher icon ember-graphql

Improve tests

Open villander opened this issue 7 years ago • 3 comments

We have almost 80% coverage, which is very good. But the place we least test is where you most need, in apollo service, the heart of the addon. We need help with this.

image

villander avatar Feb 18 '18 03:02 villander

@villander any interest in a PR to get code coverage included as part of our CodeClimate runs?

https://codeclimate.com/github/bgentry/ember-apollo-client

bgentry avatar Feb 18 '18 18:02 bgentry

@villander I'm curious about the status of this now. Any change you can rerun the coverage report?

josemarluedke avatar Aug 01 '19 00:08 josemarluedke

While a good unit test coverage is good, I think we need to improve our tests by adding more application/rendering tests. We need to make sure we interact well with ember, we should create more tests cases to mimic how users use this project. Today we mock a lot of methods to do testing, we should minimize that.

josemarluedke avatar Sep 25 '19 04:09 josemarluedke