fastboot-aws icon indicating copy to clipboard operation
fastboot-aws copied to clipboard

Option to force https

Open simonihmig opened this issue 8 years ago • 5 comments

If FORCE_HTTPS is set, will make a redirect if not using https at the Load Balancer. Parts of it shamelessly stolen from https://github.com/ember-fastboot/fastboot-app-server/issues/36.

@tomdale ping!

simonihmig avatar Mar 01 '17 15:03 simonihmig

I've been using this for a while and occasionally getting:

TypeError: Cannot read property 'indexOf' of undefined
    at forceHttpsMiddleware (/var/app/current/lib/force-https.js:5:80)

in the logs.

ghost avatar Mar 09 '17 08:03 ghost

@erkarl thanks, indeed if the user agent header is undefined this would cause this exception. I just pushed a little change that should hopefully fix this!

simonihmig avatar Mar 09 '17 10:03 simonihmig

@simonihmig thanks - going to test it :)

ghost avatar Mar 09 '17 10:03 ghost

@simonihmig working just great so far :)

ghost avatar Apr 01 '17 10:04 ghost

@erkarl thanks, good to know!

@tomdale when you have recovered from EmberConf, would you consider merging this? 😉

simonihmig avatar Apr 01 '17 19:04 simonihmig