fastboot-app-server icon indicating copy to clipboard operation
fastboot-app-server copied to clipboard

Cache middleware fails to intercept response if chunkedResponse is enabled

Open reidab opened this issue 6 years ago • 1 comments

When a cache (like https://github.com/tomdale/fastboot-redis-cache) is provided, the Express server builds middleware to read/write cache entries.

To grab responses, it replaces the implementation of res.send with one that stores to the cache here.

When chunked responses are enabled res.write is called instead of res.send, so nothing is ever written to the cache.

Using something like https://github.com/axiomzen/express-interceptor (or implementing similar techniques) would solve this issue.

reidab avatar Jun 07 '18 19:06 reidab

@reidab I think that's the exact issue I was having here: https://github.com/ember-fastboot/fastboot-app-server/pull/89. I hacked around it by modifying fasboot-app-server to use res.write and res.end instead of res.send.

mhluska avatar Oct 10 '18 05:10 mhluska