ember-cli-fastboot icon indicating copy to clipboard operation
ember-cli-fastboot copied to clipboard

If an error is thrown during fastboot rendering it still returns a 200 instead of non-200

Open rileyhilliard opened this issue 6 years ago • 1 comments

Issue: Fastboot responds with a 200 when an error is thrown during the fastboot rendering cycle, however it is unpredictable to say that the rendering was successful. In most cases, there will be some level of mangled HTML returned by fastboot. This also makes writing tests against fastboot error scenarios difficult because there is no way to know there was an error encountered other than by checking that rendered state is missing from the delivered HTML payload.

Expectation: Fastboot should return a non-200 and allow for the application error handling to enter an error substate.

Reproduction Repo: https://github.com/rileyhilliard/fastboot-errors

rileyhilliard avatar Oct 09 '19 17:10 rileyhilliard

Thanks to @rwjblue - https://github.com/emberjs/ember.js/pull/18553 has the fix for rejecting promise upon hitting an error in the component.

@rileyhilliard can you verify this PR resolves the issue reported here. Thank you.

dnalagatla avatar Nov 18 '19 17:11 dnalagatla