ember-asset-loader icon indicating copy to clipboard operation
ember-asset-loader copied to clipboard

Add the script tag after-render

Open stefanpenner opened this issue 7 years ago • 7 comments

Kinda strange to add to the DOM during just any period, we likely want this to always happen when stuff has settled down.

In-theory this could be made pluggable, allowing an application to provide an alternative schedular.

import { setScriptScheduler } from '...';

setScriptScheduler(function(cb) {
  schedular.scheduleWork('afterContentPaint', cb);
});

cc @scalvert

stefanpenner avatar May 26 '17 16:05 stefanpenner

Rebased this on top of latest master, and fixed the two failing assertions (both around service.loadAsset() rejecting).

@stefanpenner / @trentmwillis - This is ready for another look.

rwjblue avatar Aug 11 '17 13:08 rwjblue

@stefanpenner - Mind rebasing?

rwjblue avatar Mar 19 '18 14:03 rwjblue

@stefanpenner mind rebasing? please

villander avatar Jan 09 '19 19:01 villander

sure

stefanpenner avatar Jan 09 '19 21:01 stefanpenner

@stefanpenner I'd love to see this merge, you want some help?

villander avatar Jan 23 '19 21:01 villander

@villander yes please

stefanpenner avatar Mar 12 '19 00:03 stefanpenner

@stefanpenner conflicts solved by #81

villander avatar Apr 16 '19 04:04 villander