ember-native-class-codemod icon indicating copy to clipboard operation
ember-native-class-codemod copied to clipboard

Error logging unclear

Open pzuraq opened this issue 6 years ago • 2 comments

Objective:

  • Every JS/TS file that was not migrated should be listed in the log
  • The log consumer should be considered the developer and any content should be understandable and actionable
  • When migration for a file is "bailed out" we should log the line and column number of the "offending" code that caused us to bail

Details

The log is helpful, but the messages can be a little bit unclear. Going to list out examples here as I find them:

  • When the object cannot be transformed because it has an unknown computed assigned:
Transform not supported - need option '--decorators=true' or the property type CallExpression can not be transformed

The --decorators option was being used so that shouldn't be part of the message, and the message should indicate that there was property that we couldn't transform, and ideally the name of the property.

pzuraq avatar Jan 30 '19 17:01 pzuraq

Updated the description a bit, with some high level objectives.

@pzuraq - Mind reviewing?

rwjblue avatar Jun 23 '19 23:06 rwjblue

Looks good. I think ideally we should include files/folders that may be confusing at first, like the Data files, as well.

pzuraq avatar Jun 24 '19 18:06 pzuraq