ember-native-class-codemod icon indicating copy to clipboard operation
ember-native-class-codemod copied to clipboard

--classic-decorator cli option isn't respected

Open 22a opened this issue 5 years ago • 3 comments

Running this codemod with --classic-decorator=false still replaces objects with classes wrapped with the @classic decorator:

npx ember-native-class-codemod http://intercom.test/app-store --type=route --classic-decorator=false app/routes
Screenshot 2019-10-14 at 15 36 41

Manually inverting the default works as expected.

22a avatar Oct 14 '19 14:10 22a

I’ve put together a potential fix for this here https://github.com/ember-codemods/ember-native-class-codemod/pull/212

patocallaghan avatar Oct 26 '19 09:10 patocallaghan

Any update on this? we have a lot of stuff and there's a lot of classic decorator annotations that aren't really needed with no way to prevent them.

rtablada avatar Nov 17 '21 17:11 rtablada

This has not been solved yet. A workaround is using an empty string, which resolves to false npx ember-native-class-codemod http://localhost:4200 --decorators=true --classic-decorator='' app/...

GerritSommer avatar Mar 24 '22 10:03 GerritSommer