ember-modules-codemod icon indicating copy to clipboard operation
ember-modules-codemod copied to clipboard

chore: bump jscodeshift in order to try fix optional chaining transform error

Open linearza opened this issue 1 year ago • 4 comments

Primarily bumps the jscodeshift version to ^0.11.0 in order to unblock and support optional chaining conversions.

https://github.com/ember-codemods/ember-modules-codemod/issues/226

linearza avatar Oct 19 '23 14:10 linearza

Any news on when this will be merged?

Pasgru avatar Oct 25 '23 11:10 Pasgru

@Pasgru just to say, as a temporary fix, what I did to unblock myself, was to just comment out the files throwing this error, run the codemod, and then uncomment after. Bit brutish and we dont use optional chaining extensively yet, so might not be appropriate for your use case, but got us going again

linearza avatar Oct 25 '23 11:10 linearza

@Pasgru just to say, as a temporary fix, what I did to unblock myself, was to just comment out the files throwing this error, run the codemod, and then uncomment after. Bit brutish and we dont use optional chaining extensively yet, so might not be appropriate for your use case, but got us going again

Yeah I guess this is the best option. Thanks for the fast reply

Pasgru avatar Oct 25 '23 11:10 Pasgru

Would love to see this merged.

jagthedrummer avatar Mar 21 '24 18:03 jagthedrummer