eslint-plugin-ember
eslint-plugin-ember copied to clipboard
avoid-leaking-state-in-ember-objects should warn about myProp: A()
We recently found that the rule does not warn you if you do:
myProp: A()
And yet the state is leaked. I bet the same happens with EmberObject()
.
Shouldn't this rule also apply in these cases?
Completely agree, we should specfically ensure that Ember.A()
is still flagged.
@rwjblue I'd like to try fixing this. Never worked on an eslint rule before, so it's good practice. Is that ok?
There it goes! Any feedback is much appreciated.