ember-page-title

ember-page-title copied to clipboard

Bumps [terser](https://github.com/terser/terser) from 4.8.0 to 4.8.1. Changelog Sourced from terser's changelog. v4.8.1 (backport) Security fix for RegExps that should not be evaluated (regexp DDOS) Commits See full diff in compare...

dependabot[bot]

Why does `{{page-title}}` return `''`?

2

I'm just curious why the code returns an empty string instead of nothing at all. To wit: ```js compute(params, _hash) { let hash = { ..._hash, id: this.tokenId, title: params.join(''),...

muziejus

Title and Screen Readers

8

I've noticed the title isn't updated until after the page loads. When using a screen-reader this is problematic as the title is read before the page has finished loading. This...

camskene

The release script is on the `docs/` and `test-app/` workspaces, but not in `addon/` where it should be. Also this might be a good time to switch to release-it?

knownasilya

Merge `page-title` and `page-title-list` services?

1

A while ago, a `page-title` service was introduced as a means to have a public `titleDidUpdate` hook, and also because the entire `page-title-list` service was/is considered private. I would like...

bertdeblock

Introduce Ember CLI AddonDocs

3

Migrate to https://ember-learn.github.io/ember-cli-addon-docs/docs from current basic documentation page. This provides consistency with other addons and flexibility to easily add new information.

raido

Install ember-cli-memory-leak-detector

6

This install [ember-cli-memory-leak-detector](https://github.com/steveszc/ember-cli-memory-leak-detector) Congrats! No memory leaks were detected in this add-on (based on the coverage of the existing test suite) PS This PR came out of the EmberConf contributor's...

steveszc

ember-engine + ember-page-title fails

25

Stack trace ```javascript ember.debug.js:26518 Error: Assertion Failed: Expected component:head-content to resolve to an Ember.Component but instead it was [object Object]. at assert (ember.debug.js:13695) at validateType (ember.debug.js:13002) at Class.resolve (ember.debug.js:12704) at...

sarathkumarbaskaran

We probably should add comment block so IDEs could give hints of expected parameters OR provide TypeScript interface file. I think proper JSDoc for starters would be nice. This helper...

raido

Document example of ember-cli-head integration

1

Integration with `ember-cli-head` can be done with v6.1.0 like this: ``` // app/services/page-title.js import EmberPageTitleService from 'ember-page-title/services/page-title'; export default class PageTitleService extends EmberPageTitleService { @service headData; titleDidUpdate(title) { this.headData.ogTitle =...

raido