ember-fetch icon indicating copy to clipboard operation
ember-fetch copied to clipboard
verified publisher icon ember-cli

update to v3.28 with ember-cli-update

Open mansona opened this issue 2 years ago • 3 comments

mansona avatar Nov 09 '23 22:11 mansona

hasn't this already been done on https://github.com/ember-cli/ember-fetch/pull/741 ?

void-mAlex avatar Nov 13 '23 12:11 void-mAlex

It hadn't actually, I moved @mansona's addition from this PR into my PR recently actually 🙂 Now all tests are passing in my PR except for the Node ones but this is kind of unknown territory for me.. 😕

Pixelik avatar Nov 13 '23 18:11 Pixelik

A benefit of this PR vs #741 is that it isn't a breaking change, so apps which are not yet on node 16 (for whatever reason) can still update

tehhowch avatar Dec 15 '23 18:12 tehhowch