ember-fetch icon indicating copy to clipboard operation
ember-fetch copied to clipboard

Test ember-fetch against an embroider build

Open kiwiupover opened this issue 5 years ago • 3 comments

Adding a test scenario to test ember-fetch against embroider.

The Embroider tests are failing due to duplicates babel plugins.

info Reasons this module exists
   - "ember-cli-typescript" depends on it
   - Hoisted from "ember-cli-typescript#@babel#plugin-proposal-optional-chaining"
   - Hoisted from "@embroider#webpack#@babel#plugin-proposal-optional-chaining"
   - Hoisted from "ember-cli-babel#@babel#preset-env#@babel#plugin-proposal-optional-chaining"
Duplicates detected are:
[
  {
    "alias": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
    "dirname": "/home/travis/build/ember-cli/ember-fetch",
    "ownPass": false,
    "file": {
      "request": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
      "resolved": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js"
    }
  },
  {
    "alias": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
    "dirname": "/home/travis/build/ember-cli/ember-fetch",
    "ownPass": false,
    "file": {
      "request": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js",
      "resolved": "/home/travis/build/ember-cli/ember-fetch/node_modules/@babel/plugin-proposal-optional-chaining/lib/index.js"
    }
  }
]

kiwiupover avatar Aug 22 '20 19:08 kiwiupover

@kiwiupover this issue may be related to https://github.com/embroider-build/embroider/issues/453.

Can you try updating ember-typescript to 4-alpha?

GCheung55 avatar Aug 25 '20 08:08 GCheung55

Did updating ember-typescript address the problem?

Also @embroider/core doesn’t seem to be directly imported so that can be removed right?

GCheung55 avatar Aug 26 '20 03:08 GCheung55

@rwjblue I have added a new PR to update ember-cli-typescript to 4.0.0 https://github.com/ember-cli/ember-fetch/pull/563

kiwiupover avatar Sep 09 '20 20:09 kiwiupover