ember-exam icon indicating copy to clipboard operation
ember-exam copied to clipboard

fix: automatic import of ember-qunit and qunit in ember-mocha projects

Open ndekeister-us opened this issue 3 years ago • 8 comments

Should fix https://github.com/ember-cli/ember-exam/issues/666

It was trying to auto-import ember-qunit and qunit in projects using ember-mocha, leading to build errors


Tested

  • on a public project using [email protected], see https://github.com/ndekeister-us/Admin/pull/1
    • commit c6dec4ba829975297d00f0c3fe438f052b1bd257 -> it will now build the project and run tests (there is maybe another issue with ember-cli-mirage, see https://github.com/miragejs/ember-cli-mirage/pull/2209, but i'm not able to reproduce it anymore so maybe was linked to something wrong in my environment)
  • on a private project using [email protected]
  • on a private project using [email protected]

ndekeister-us avatar Jul 08 '21 22:07 ndekeister-us

@step2yeung @thoov may i ask for your review 🙏

ndekeister-us avatar Aug 27 '21 12:08 ndekeister-us

I've just re-tested the PR with Ghost's current main and can confirm it fixes our broken build we started seeing with 6.1.0

kevinansfield avatar Aug 31 '21 08:08 kevinansfield

Merged master to get a CI build kicked off...

rwjblue avatar Sep 07 '21 17:09 rwjblue

@rwjblue they are failing because of this error

liquid-fire/templates/components/liquid-outlet.hbs: Assertion Failed: Named outlets were removed in Ember 4.0. See https://deprecations.emberjs.com/v3.x#toc_route-render-template for guidance on alternative APIs for named outlet use cases. ('liquid-fire/templates/components/liquid-outlet.hbs' @ L18:C10) 

liquid-fire (which is used by ember-cli-addon-docs) use named outlets in this component

But

I made a PR in this repo -> https://github.com/ember-cli/ember-exam/pull/720 to, at least, update ember-cli-addon-docs to a recent version but i'm not sure of what we should do as ember-cli-addon-docs is now in maintenance mode so even if we fix the "issue" in liquid-fire repo, we may have new issues with future Ember versions

ndekeister-us avatar Sep 07 '21 23:09 ndekeister-us

@rwjblue made PR https://github.com/ember-cli/ember-exam/pull/720 to fix ember-beta/canary scenarios (mainly by updating https://github.com/ember-learn/ember-cli-addon-docs/)

ndekeister-us avatar Sep 17 '21 15:09 ndekeister-us

Rebased with master, tested again on

  • https://github.com/ndekeister-us/Admin/pull/1 (project using ember-mocha) -> build pass, tests are running
  • on a private project using [email protected]
  • on a private project using [email protected]

Locally

  • test:ember
  • ember try:one ember-canary ✅ (didn't tested the other, but if canary pass it should be fine)

ndekeister-us avatar Dec 24 '21 15:12 ndekeister-us

@ndekeister-us @rwjblue Is there anything blocking merge/release of this? This seems to be necessary to get ember-mocha apps on the latest ember-exam & Ember 3.28 and beyond.

(sorry for the ping)

maxfierke avatar Mar 09 '22 15:03 maxfierke

Maybe ping @Turbo87 (same, sorry for the ping)

ndekeister-us avatar Mar 17 '22 20:03 ndekeister-us

Closing as I guess it will never be merged (see https://rfcs.emberjs.com/id/0858-deprecate-ember-mocha/ ; https://github.com/emberjs/ember.js/pull/20402)

ndekeister-us avatar May 05 '23 15:05 ndekeister-us