ember-exam
ember-exam copied to clipboard
fix: automatic import of ember-qunit and qunit in ember-mocha projects
Should fix https://github.com/ember-cli/ember-exam/issues/666
It was trying to auto-import ember-qunit
and qunit
in projects using ember-mocha
, leading to build errors
Tested
- on a public project using
[email protected]
, see https://github.com/ndekeister-us/Admin/pull/1- commit
c6dec4ba829975297d00f0c3fe438f052b1bd257
-> it will now build the project and run tests (there is maybe another issue with ember-cli-mirage, see https://github.com/miragejs/ember-cli-mirage/pull/2209, but i'm not able to reproduce it anymore so maybe was linked to something wrong in my environment)
- commit
- on a private project using
[email protected]
- on a private project using
[email protected]
@step2yeung @thoov may i ask for your review 🙏
I've just re-tested the PR with Ghost's current main
and can confirm it fixes our broken build we started seeing with 6.1.0
Merged master to get a CI build kicked off...
@rwjblue they are failing because of this error
liquid-fire/templates/components/liquid-outlet.hbs: Assertion Failed: Named outlets were removed in Ember 4.0. See https://deprecations.emberjs.com/v3.x#toc_route-render-template for guidance on alternative APIs for named outlet use cases. ('liquid-fire/templates/components/liquid-outlet.hbs' @ L18:C10)
liquid-fire (which is used by ember-cli-addon-docs) use named outlets in this component
But
- liquid-fire is not very active (no new tags since 2019)
- ember-cli-addon-docs is in maintenance mode
I made a PR in this repo -> https://github.com/ember-cli/ember-exam/pull/720 to, at least, update ember-cli-addon-docs to a recent version but i'm not sure of what we should do as ember-cli-addon-docs is now in maintenance mode so even if we fix the "issue" in liquid-fire repo, we may have new issues with future Ember versions
@rwjblue made PR https://github.com/ember-cli/ember-exam/pull/720 to fix ember-beta/canary scenarios (mainly by updating https://github.com/ember-learn/ember-cli-addon-docs/)
Rebased with master, tested again on
- https://github.com/ndekeister-us/Admin/pull/1 (project using ember-mocha) -> build pass, tests are running
- on a private project using [email protected] ✅
- on a private project using [email protected] ✅
Locally
-
test:ember
✅ -
ember try:one ember-canary
✅ (didn't tested the other, but if canary pass it should be fine)
@ndekeister-us @rwjblue Is there anything blocking merge/release of this? This seems to be necessary to get ember-mocha apps on the latest ember-exam & Ember 3.28 and beyond.
(sorry for the ping)
Maybe ping @Turbo87 (same, sorry for the ping)
Closing as I guess it will never be merged (see https://rfcs.emberjs.com/id/0858-deprecate-ember-mocha/ ; https://github.com/emberjs/ember.js/pull/20402)