ember-cli-htmlbars icon indicating copy to clipboard operation
ember-cli-htmlbars copied to clipboard

warning introduced by plugins not caching, is not as actionable as it could

Open stefanpenner opened this issue 8 years ago • 11 comments

https://github.com/ember-cli/ember-cli-htmlbars/pull/90/files#diff-fc695117845e9b76dfb1841d2221ac7cR133

should include a URL to "how to fix it".

stefanpenner avatar Aug 18 '16 18:08 stefanpenner

Also, we need docs here explaining how to fix this.

stefanpenner avatar Aug 19 '16 06:08 stefanpenner

FWIW, the AST plugin system is not public API. I didn't document this for that reason.

rwjblue avatar Aug 19 '16 12:08 rwjblue

It's documented on the home page. (.___________ .)

I'm currently using this in my addon https://github.com/tim-evans/ember-page-title, and am encountering this error.

tim-evans avatar Sep 15 '16 19:09 tim-evans

@tim-evans - What home page?

rwjblue avatar Sep 15 '16 20:09 rwjblue

Oh, the README. I figured what I was doing wrong :)

tim-evans avatar Sep 15 '16 20:09 tim-evans

Sorry if I'm being a bother~

tim-evans avatar Sep 15 '16 20:09 tim-evans

I'm not sure what release/update exactly introduced it, but I'm not getting these warnings on my project:

DEPRECATION: ember-cli-htmlbars-inline-precompile is opting out of caching due to an AST plugin that does not provide a caching strategy: `ember-css-modules`.
DEPRECATION: ember-cli-htmlbars-inline-precompile is opting out of caching due to an AST plugin that does not provide a caching strategy: `transform-liquid-with-as-to-hash`.
DEPRECATION: ember-cli-htmlbars is opting out of caching due to an AST plugin that does not provide a caching strategy: `ember-css-modules`.
DEPRECATION: ember-cli-htmlbars is opting out of caching due to an AST plugin that does not provide a caching strategy: `transform-liquid-with-as-to-hash`.
DEPRECATION: ember-cli-htmlbars is opting out of caching due to an AST plugin that does not provide a caching strategy: `transform-liquid-with-as-to-hash`.

There's two different modules complaining about this issue, caused by two other modules. I didn't find any open issues for the other modules...

Does anybody have a hint how to fix this? That could be a starting point for proper docs.

jzaefferer avatar Sep 22 '16 13:09 jzaefferer

I think it's using the wrong hook in index.js for those addons:

See https://github.com/tim-evans/ember-page-title/commit/8918d709c4599b6bdc8676059f17a23a7262adb5 for what I did to fix it.

tim-evans avatar Sep 22 '16 14:09 tim-evans

Thanks for the link, but as a user of those addons (not an author), that doesn't help me. I've got no idea what's going on in that code...

jzaefferer avatar Sep 22 '16 14:09 jzaefferer

@jzaefferer please open an issue on the offending add-on.

stefanpenner avatar Sep 22 '16 14:09 stefanpenner

Filed on for ember-css-modules: https://github.com/salsify/ember-css-modules/issues/50

jzaefferer avatar Sep 22 '16 15:09 jzaefferer