ember-cli-eslint icon indicating copy to clipboard operation
ember-cli-eslint copied to clipboard

Should work without a `tests` folder?

Open Bouke opened this issue 6 years ago • 4 comments

My ember app doesn't have tests, hence I removed the test folder. However when this module is added, the following error message will be printed: broccoli-persistent-filter:EslintValidationFilter: Expected Broccoli node, got null for inputNodes[0].

Repro:

ember new --yarn notests
cd notests
rm -rf tests
yarn build

Gives the following output:

yarn run v1.10.1
$ ember build
⠋ Buildingbroccoli-persistent-filter:EslintValidationFilter: Expected Broccoli node, got null for inputNodes[0]


Stack Trace and Error Report: /var/folders/z3/r5mpk9zx2x9g2ldj8jsxbgw80000gn/T/error.dump.83017b5fd1c6e7535e57ba952c5b8f03.log
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Bouke avatar Oct 09 '18 18:10 Bouke

I'm not sure that this is the right place for this issue. The error pops up in the EslintValidationFilter class, but only because it is being called incorrectly by the build pipeline. Since you linked https://github.com/ember-cli/ember-cli/issues/8094 I assume you use the regular Ember.js build pipeline, so I'd rather open the issue on the ember-cli repo again, and close this one here.

Turbo87 avatar Oct 13 '18 12:10 Turbo87

@Bouke I have the same issue. Have you found how to fix it?

alexborovkov avatar Apr 16 '19 09:04 alexborovkov

I simply created the test folder so it doesn't trigger this bug anymore. :shipit:

Bouke avatar Nov 18 '19 19:11 Bouke

I still get this. Even with the tests folder created

yandiro avatar Jun 21 '20 10:06 yandiro