ember-cli-eslint
ember-cli-eslint copied to clipboard
ember-cli
Add throwOnError and throwOnWarn options
I wanted this functionality so I added it. The only caveat that I found was that this causes the build to fail and hang instead of fail and quit.
An example is:
As you can see the build failed but I wasn't thrown back to Terminal prompt but was instead stuck until I quit the current running process: On Windows with CTRL+C
Is this the wanted behavior or should this be fixed as well?
Hey friends, any possibility to add this? Don't think it hurts anything. Just expands the features.
when you use ember serve and someone introduces an ESLint issue, does it quit the process then?
Right now if someone introduces an ESLint error the process hangs until the error is fixed. It still rebuilds on changes
tbh I'm not convinced by this functionality. showing a "stack trace and error report" should be reserved for when something is really going terribly wrong, but not when linting fails 🤔
Well I understand it's not going to be wanted or needed by everyone or even most people. That's why it's an option. :)
@Turbo87 I'd like to add a +1 for this option. We want eslint errors to be treated as regular JS syntax errors, so they are fixed immediately instead of being piled up. The option is absolutely a value-add.
Given https://github.com/ember-cli/rfcs/pull/121 I'm not sure how this would work in the future 🤔
@Turbo87 This addon will still be available though even if that RFC gets implemented? BTW great slides! Can't wait to see the recording for your talk
the addon will still be here, but will likely not be maintained anymore at the same level as before, unless someone from the community steps up and takes over.
@Turbo87 I would still like this here. Even if the RFC gets implemented. Not everyone updates their app to the latest ASAP.
Would help me out if the was merged in :)