ember-cli-app-version icon indicating copy to clipboard operation
ember-cli-app-version copied to clipboard

App version in Ember console debug statements

Open slindberg opened this issue 10 years ago • 6 comments

Just started using this in our app, so thanks :smile:

Since the addon defines an initializer that registers the app as an ember library, I was surprised to see that it wasn't listed in the normal library version debug output. After a little digging it appears that initializers run after that method is called, so the app version isn't in the list when it's printed. Not a big deal, but I've definitely found it handy to find the version in the console without opening the ember inspector and clicking the info tab (I used to call Ember.libraries.register in app/app.js directly).

I would have opened a PR, but I can't figure out how to use addon hooks to run code before Ember.Application#init is called. The only thing I could think of was to add an inline script using the contentFor hook, but that ends up violating CSP. Do you have any idea how to do this?

slindberg avatar Mar 09 '15 03:03 slindberg

Seeing version number in the console would be very nice, but it would only be available in development because production build suppresses debug messages.

With contentFor, you the version number might get lost when deploying without using generated index.html. Initializer works in that respect, because it's always included as part of app code.

Let's see what others have to say about this.

taras avatar Mar 09 '15 12:03 taras

How about proposing Ember move logLibraryVersions to an initializer?

lukemelia avatar Mar 09 '15 12:03 lukemelia

@lukemelia great idea!

taras avatar Mar 09 '15 16:03 taras

I'm fairly sure that we can just do this before app boot via one of the JS context contentFor hooks.

Something conceptually like: https://github.com/jkarsrud/ember-cli-defeatureify/blob/master/index.js#L20-L22

rwjblue avatar Mar 12 '15 04:03 rwjblue

This would remove the need for the guard added in #14, and remove the need for an initializer at all.

rwjblue avatar Mar 12 '15 04:03 rwjblue

This would be neat and help to push the version together with the error to i.e. bugsnag

MichaelVdheeren avatar Mar 28 '15 07:03 MichaelVdheeren