eslint-plugin-ember-best-practices icon indicating copy to clipboard operation
eslint-plugin-ember-best-practices copied to clipboard

Published 20 hours ago • verified publisher icon ember-best-practices

Merge with eslint-plugin-ember

Open Turbo87 opened this issue 7 years ago • 7 comments

I don't know why this project was started when we also have https://github.com/netguru/eslint-plugin-ember but I think having two projects that try to do similar things is just wasting resources.

I would like to propose to merge this project with https://github.com/netguru/eslint-plugin-ember under a shared GitHub org so that everyone can act as a maintainer.

see https://github.com/netguru/eslint-plugin-ember/issues/88

Turbo87 avatar Jul 07 '17 06:07 Turbo87

This project started prior to the net guru project being renamed and popularized. I'm all for a shared collaboration in a repo with shared ownership. Happy to host that in this org (the org name seems to fit the purpose) if others are also 👍.

rwjblue avatar Jul 07 '17 13:07 rwjblue

I'm all for merging. I also think it makes sense to merge these rules into the netguru ones, and ultimately move that project under this org. We can all act as maintainers of the newly merged one.

scalvert avatar Jul 07 '17 15:07 scalvert

Awesome to see that the two efforts are (or will be) combined! 🥇

What's the state of this merge?

It seems like the netguru repo has been moved to https://github.com/ember-cli/eslint-plugin-ember, but this one also seems to be active.

If eslint-plugin-ember has superseded this one, how about adding a large warning/note on the readme in this repo (I accidentally added this one to our project, before realising that a similar plugin existed under the ember-cli org).

sandstrom avatar Sep 27 '17 16:09 sandstrom

If eslint-plugin-ember has superseded this one, how about adding a large warning/note on the readme in this repo

I think that would be a good idea. Feel free to open a PR for this :)

Turbo87 avatar Sep 27 '17 18:09 Turbo87

@Turbo87 Happy to submit a PR, just want to check with the repo-owner first.

@rwjblue Should I PR a readme change directing people to eslint-plugin-ember? (see my comment above)

sandstrom avatar Sep 28 '17 12:09 sandstrom

I'm unsure about the other maintainers, but I never received any real notice of the merge occurring or being completed. If it has, then we likely have diverged again as there has been ongoing work in this repo.

trentmwillis avatar Sep 30 '17 00:09 trentmwillis

Agreed. We need to make a meta issue to evaluate and migrate or deprecate (with guidance) each individual rule.

A deprecation notice is a tad premature until we also provide guidance...

rwjblue avatar Sep 30 '17 03:09 rwjblue