Remove need for Handlebars.runtime.js

[knownasilya]

Since most of the items already have the template precompiled code, Ember.Handlebars.compile shouldn't be used (like in the core). This will allow for users of this framework to have performance benefits.

[asaf]

@knownasilya I guess you meant remove need for Handlebars.js and not the runtime, It's more important for me to clean this up to avoid the need to include the full handlebar js instead of the runtime,

I'll leave this issue open and will try to work on it on the next version,

Thanks.

[knownasilya]

Yes that is what I meant, and I'm glad you're aware of the issue :) On Jan 21, 2014 3:40 AM, "Asaf Shakarchi" [email protected] wrote:

@knownasilya https://github.com/knownasilya I guess you meant remove need for Handlebars.js and not the runtime, It's more important for me to clean this up to avoid the need to include the full handlebar js instead of the runtime,

I'll leave this issue open and will try to work on it on the next version,

Thanks.

— Reply to this email directly or view it on GitHubhttps://github.com/ember-addons/bootstrap-for-ember/issues/87#issuecomment-32829755 .

[derekbassett]

Is this planned to be fixed in the next release? The problem appears to be on line 404 of bs-core.max.js.

[willt]

bump bump... Any movement on this? Would be very helpful.

[ioleo]

@knownasilya this seems to me priority 1 issue.. any news on this?

[cah-brian-gantzler]

Started using these components and discovered this as well when attempting to build a prod version. Shouldn't be too hard to replace the line with the compiled version.

+1

[ComboStyle]

I had many errors till i recognized that i used the runtime instead of the full version, kinda annoying to use the full handlebar (too big and slow)

[asaf]

Assigned to the next version.

[asaf]

Should be resolved by #154

[Stanback]

This fixes the dependency for bs-core, however it looks like there are still several components, e.g. app/scripts/components/BsPill.coffee, that rely on Ember.Handlebars.compile(...)

Do those need to be updated as well?

[avanov]

The same issue with BsTabs.

[amedrz]

Hi guys, any idea of when this milestone will be finished so that you can release this fix within the next version?

Many thanks

[ballPointPenguin]

Likewise. This bug has broken my application in production for many weeks.

[drewcovi]

Agreed, how did #154 even seem to resolve this issue?

[unionups]

Аs a workaround include the full version of Handlebars and not only runtime.

This is somewhat non-standard and discouraged, but suppose that due to a requirement in your application that you need to use the full version of Handlebars even in the production environment. You would simply provide the path to the EmberApp constructor:

 var app = new EmberApp({
   vendorFiles: {
     'handlebars.js': {
       production: 'bower_components/handlebars/handlebars.js'
     }
   }
 });

[drewcovi]

@asaf I don't understand why this issue was ever closed. That referenced merge only added ItemPaneView.

[asaf]

@drewcovi Reopened, if someone can send a PR it'll be welcomed.

10x