bootstrap-for-ember icon indicating copy to clipboard operation
bootstrap-for-ember copied to clipboard

Before you could not add text to progessbars. With this minor fix you ca...

Open toovy opened this issue 11 years ago • 4 comments

Use the block helpers of bs-progress and bs-progressbar to create progress bars with custom text.

toovy avatar May 15 '14 09:05 toovy

@toovy Why not just replace the Complete text to a property ?

asaf avatar May 15 '14 13:05 asaf

@asaf the span.sr-only is only detected by screen readers afaik. That would not solve the problem. As seen here http://getbootstrap.com/components/#progress you can add text directly under the div.progress-bar. Furthermore the problem is that you might want to add even more dynamic segments to the output. See this example:

{{#unless is_amount_open}}
    {{#bs-progress}}
        {{#bs-progressbar type="success" progress=progress}}
            {{format_fn amount_as_currency}}{{currency}} {{progress}}%
        {{/bs-progressbar}}
    {{/bs-progress}}
{{/unless}}

toovy avatar May 15 '14 13:05 toovy

@toovy Fair enough, I am not committing yet because the documentation needs to get updated first,

If you have time then feel free to add this code sample into the docs or I'll do it later,

Thanks!

asaf avatar May 15 '14 13:05 asaf

@asaf I've added a small chapter, hope that it is ok.

toovy avatar May 15 '14 13:05 toovy