embassy icon indicating copy to clipboard operation
embassy copied to clipboard

RP235x: Add the new FJOIN_RX_xxx options

Open pferreir opened this issue 1 year ago • 4 comments

This requires changes in pio too if we want the example to work (ping @CBJamo). Probably a new release?

pferreir avatar Sep 23 '24 22:09 pferreir

Build error can be fixed by depending on pio-rs from this pr: https://github.com/rp-rs/pio-rs/pull/66

CBJamo avatar Sep 23 '24 22:09 CBJamo

should we wait for https://github.com/rp-rs/pio-rs/pull/66 before merge? I see there's still quite a bit of discussion there.

Dirbaio avatar Oct 13 '24 20:10 Dirbaio

I think we should wait. It's not clear if the pio-rs pr will need to change more or not. This pr is also out of sync with the current state of that pr.

CBJamo avatar Oct 14 '24 00:10 CBJamo

Removed the rp2350 flags in pio packages. Anything else?

pferreir avatar Oct 19 '24 08:10 pferreir

I think this kind of got forgotten. Is this PR still relevant?

pferreir avatar Dec 29 '24 11:12 pferreir

afaict it's still waiting on https://github.com/rp-rs/pio-rs/pull/66

Dirbaio avatar Dec 29 '24 12:12 Dirbaio

OK, just wanted to make sure it doesn't go stale...

On Sun, 29 Dec 2024, 12:14 Dario Nieuwenhuis, @.***> wrote:

afaict it's still waiting on rp-rs/pio-rs#66 https://github.com/rp-rs/pio-rs/pull/66

— Reply to this email directly, view it on GitHub https://github.com/embassy-rs/embassy/pull/3369#issuecomment-2564705630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAVC4LAKNFLBG5URMP4UL2H7RRHAVCNFSM6AAAAABOW7PXTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUG4YDKNRTGA . You are receiving this because you authored the thread.Message ID: @.***>

pferreir avatar Dec 29 '24 12:12 pferreir